Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/croscore-fonts.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/croscore-fonts-1.21.0-1.fc16.src.rpm Description: This package contains a collections of fonts that offers improved on-screen readability characteristics and the pan-European WGL character set and solves the needs of developers looking for width-compatible fonts to address document portability across platforms.
I'll take this for review. BTW isn't it better using %{version} in Source0? and you better follow up the steps in http://fedoraproject.org/wiki/Font_package_lifecycle too. I don't see this font in http://fedoraproject.org/wiki/Category:In-progress_fonts.
updated both the things: 1) package is updated at same location (no release bump yet) 2) https://fedoraproject.org/wiki/Croscore_fonts koji scratch build for f18 -> koji.fedoraproject.org/koji/taskinfo?taskID=3931981
Please add a google foundry prefix and the fontconfig rules to subsititute for arial/tnr & liberation (the inverse rules probably need addition to liberation too)
updated but I still need help in writing those correct fontconfig files. Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/google-croscore-fonts.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/google-croscore-fonts-1.21.0-1.fc16.src.rpm
You can check /etc/fonts/conf.d/30-metric-aliases.conf for the references.
Updated to Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/google-croscore-fonts.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/google-croscore-fonts-1.21.0-2.fc16.src.rpm koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3935561
As the description for SymbolNeu says it's compatible font to Symbol. I guess you better have the substitution for that? and you shouldn't have any relationship to sans-serif for that.
Thanks for the comment. Updated at the same location as given in comment#6
Here we go: * rpmlint result: google-croscore-fonts.src: W: no-url-tag google-croscore-fonts.src: W: invalid-url Source0: http://gsdview.appspot.com/chromeos-localmirror/distfiles/croscorefonts-1.21.0.tar.gz HTTP Error 405: Method Not Allowed 1 packages and 0 specfiles checked; 0 errors, 2 warnings. google-croscore-arimo-fonts.noarch: W: no-url-tag google-croscore-arimo-fonts.noarch: W: no-documentation google-croscore-cousine-fonts.noarch: W: no-url-tag google-croscore-cousine-fonts.noarch: W: no-documentation google-croscore-fonts-common.noarch: W: no-url-tag google-croscore-symbolneu-fonts.noarch: W: no-url-tag google-croscore-symbolneu-fonts.noarch: W: no-documentation google-croscore-tinos-fonts.noarch: W: no-url-tag google-croscore-tinos-fonts.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 9 warnings. + package name meets the naming guidelines + the spec file name matches %{name}.spec + package meets the packaging guidelines + package meets the licensing guidelines + License field has the actual license + License file is available in the package + the spec file is written in American English + the spec file is legible + the sources matches the upstream source + the package can be built into binary rpms * no locale files available * no shared libraries available + package owns directories it creates + package consistently uses macros * no large documentation files available * no devel files available * no desktop files available Is it maybe a good idea to move the source URL to the comment and have the name of tarball in the Source field perhaps? otherwise it looks good to me. APPROVED.
New Package SCM Request ======================= Package Name: google-croscore-fonts Short Description: The width-compatible fonts for improved on-screen readability Owners: pnemade Branches: 17 InitialCC: fonts-sig i18n-team
Thanks Akira for the review.
Git done (by process-git-requests). Corrected branch.
google-croscore-fonts-1.21.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/google-croscore-fonts-1.21.0-2.fc17
google-croscore-fonts-1.21.0-2.fc17 has been pushed to the Fedora 17 testing repository.
Package Change Request ====================== Package Name: google-croscore-fonts New Branches: f15 f16 Owners: pnemade
Git done (by process-git-requests).
google-croscore-fonts-1.21.0-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/google-croscore-fonts-1.21.0-2.fc15
google-croscore-fonts-1.21.0-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/google-croscore-fonts-1.21.0-2.fc16
google-croscore-fonts-1.21.0-2.fc17 has been pushed to the Fedora 17 stable repository.
google-croscore-fonts-1.21.0-2.fc16 has been pushed to the Fedora 16 stable repository.
google-croscore-fonts-1.21.0-2.fc15 has been pushed to the Fedora 15 stable repository.