Bug 805487 - Review Request: logback - A Java logging library
Summary: Review Request: logback - A Java logging library
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Marek Goldmann
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 806678 (view as bug list)
Depends On: 806669
Blocks: 809950 821284
TreeView+ depends on / blocked
 
Reported: 2012-03-21 13:08 UTC by Mary Ellen Foster
Modified: 2012-05-29 10:30 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-26 07:38:38 UTC
Type: ---
Embargoed:
mgoldman: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
build.log from local mock build (95.18 KB, text/x-log)
2012-03-21 16:04 UTC, Mary Ellen Foster
no flags Details

Description Mary Ellen Foster 2012-03-21 13:08:39 UTC
Spec URL: http://mef.fedorapeople.org//logback.spec
SRPM URL: http://mef.fedorapeople.org//logback-1.0.1-1.fc16.src.rpm

Description:
Logback is intended as a successor to the popular log4j project. At present
time, logback is divided into three modules, logback-core, logback-classic
and logback-access.

The logback-core module lays the groundwork for the other two modules. The
logback-classic module can be assimilated to a significantly improved
version of log4j. Moreover, logback-classic natively implements the SLF4J
API so that you can readily switch back and forth between logback and other
logging frameworks such as log4j or java.util.logging (JUL).

The logback-access module integrates with Servlet containers, such as
Tomcat and Jetty, to provide HTTP-access log functionality. Note that you
could easily build your own module on top of logback-core.

Comment 1 Mary Ellen Foster 2012-03-21 13:11:30 UTC
This package got retired from Fedora when I didn't have time to maintain it. I now have time again and would like to get it re-added.

Comment 2 Mary Ellen Foster 2012-03-21 16:04:15 UTC
Created attachment 571756 [details]
build.log from local mock build

Here's a build.log from a local Rawhide mock build with the additional dependencies added to the buildroot

Comment 3 Mary Ellen Foster 2012-03-27 11:43:07 UTC

*** This bug has been marked as a duplicate of bug 806678 ***

Comment 4 Mary Ellen Foster 2012-03-27 13:48:45 UTC
*** Bug 806678 has been marked as a duplicate of this bug. ***

Comment 5 Marek Goldmann 2012-04-18 12:27:22 UTC
I'll take it.

Comment 6 Marek Goldmann 2012-04-18 13:47:45 UTC
I'll proceed once the janino package is fixed and available in Rawhide.

Comment 7 Marek Goldmann 2012-05-02 11:12:28 UTC
Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

=== REQUIRED ITEMS ===
[x]  Rpmlint output:

$ rpmlint SPECS/logback.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint SRPMS/logback-1.0.1-1.fc17.src.rpm 
logback.src: I: enchant-dictionary-not-found en_US
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint RPMS/noarch/logback-1.0.1-1.fc17.noarch.rpm 
logback.noarch: E: explicit-lib-dependency tomcat-lib
logback.noarch: I: enchant-dictionary-not-found en_US
logback.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/logback-1.0.1/manual/images/chapters/appenders/appender.uml
logback.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/logback-1.0.1/manual/images/chapters/appenders/appender.~ml
1 packages and 0 specfiles checked; 1 errors, 2 warnings.

This can be ommited, fals-positive.

[x]  Package is named according to the Package Naming Guidelines[1].
[x]  Spec file name must match the base package name, in the format %{name}.spec.
[x]  Package meets the Packaging Guidelines[2].
[x]  Package successfully compiles and builds into binary rpms.
[x]  Buildroot definition is not present
[x]  Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines[3,4].
[x]  License field in the package spec file matches the actual license.
License type: LGPLv2 or EPL
[x]  If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
[x]  All independent sub-packages have license of their own
[x]  Spec file is legible and written in American English.
[x]  Sources used to build the package matches the upstream source, as provided in the spec URL.
MD5SUM this package    : 43540f6b3e8f30c7aa1f59fa7db8b6c9
MD5SUM upstream package: 43540f6b3e8f30c7aa1f59fa7db8b6c9
[x]  All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines[5].
[x]  Package must own all directories that it creates or must require other packages for directories it uses.
[x]  Package does not contain duplicates in %files.
[x]  File sections do not contain %defattr(-,root,root,-) unless changed with good reason
[x]  Permissions on files are set properly.
[x]  Package does NOT have a %clean section which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). (not needed anymore)
[x]  Package consistently uses macros (no %{buildroot} and $RPM_BUILD_ROOT mixing)
[x]  Package contains code, or permissable content.
[x]  Fully versioned dependency in subpackages, if present.
[-]  Package contains a properly installed %{name}.desktop file if it is a GUI application.
[x]  Package does not own files or directories owned by other packages.
[x]  Javadoc documentation files are generated and included in -javadoc subpackage
[x]  Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlinks)
[x]  Packages have proper BuildRequires/Requires on jpackage-utils
[x]  Javadoc subpackages have Require: jpackage-utils
[-]  Package uses %global not %define
[-]  If package uses tarball from VCS include comment how to re-create that tarball (svn export URL, git clone URL, ...)
[x]  If source tarball includes bundled jar/class files these need to be removed prior to building
[x]  All filenames in rpm packages must be valid UTF-8.
[x]  Jar files are installed to %{_javadir}/%{name}.jar (see [6] for details)
[x]  If package contains pom.xml files install it (including depmaps) even when building with ant
[x]  pom files has correct add_maven_depmap

=== Maven ===
[x]  Use %{_mavenpomdir} macro for placing pom files instead of %{_datadir}/maven2/poms
[-]  If package uses "-Dmaven.test.skip=true" explain why it was needed in a comment
[-]  If package uses custom depmap "-Dmaven.local.depmap.file=*" explain why it's needed in a comment
[x]  Package DOES NOT use %update_maven_depmap in %post/%postun
[x]  Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-utils for %update_maven_depmap macro

=== Other suggestions ===
[x]  If possible use upstream build method (maven/ant/javac)
[x]  Avoid having BuildRequires on exact NVR unless necessary
[x]  Package has BuildArch: noarch (if possible)
[x]  Latest version is packaged.
[x]  Reviewer should test that the package builds in mock.
Tested on:

https://koji.fedoraproject.org/koji/taskinfo?taskID=4044336

================
*** APPROVED ***
================

Comment 8 Mary Ellen Foster 2012-05-02 14:30:40 UTC
Package change request
=======================
Package Name:      logback
Short Description: A Java logging library
Owners:            mef
Branches:          f16 f17
InitialCC:         java-sig

Comment 9 Gwyn Ciesla 2012-05-02 14:51:16 UTC
Misformatted request, please use the template.

http://fedoraproject.org/wiki/Package_SCM_admin_requests

Thanks!

Comment 10 Mary Ellen Foster 2012-05-02 15:10:00 UTC
Package Change Request
======================
Package Name: logback
New Branches: f17
Owners: mef
InitialCC: java-sig

Comment 11 Gwyn Ciesla 2012-05-03 13:11:56 UTC
Git done (by process-git-requests).

Unretired devel and f15, added f16.

Comment 12 Marek Goldmann 2012-05-08 10:57:33 UTC
Hi Mary, any chance to kick a build for F17/Rawhide?

Comment 13 Fedora Update System 2012-05-08 14:41:09 UTC
logback-1.0.1-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/logback-1.0.1-1.fc17

Comment 14 Fedora Update System 2012-05-09 16:10:39 UTC
logback-1.0.1-1.fc17 has been pushed to the Fedora 17 testing repository.

Comment 15 Volker Fröhlich 2012-05-09 22:20:21 UTC
Would you mind to ship it for F16 too?

Comment 16 Mary Ellen Foster 2012-05-11 09:44:02 UTC
logback depends on janino, which is currently in updates-testing on F16 (https://admin.fedoraproject.org/updates/FEDORA-2012-7565). Once that package makes it to stable, I'll build logback for F16 as well.

Comment 17 Fedora Update System 2012-05-20 14:51:00 UTC
logback-1.0.1-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/logback-1.0.1-1.fc16

Comment 18 Fedora Update System 2012-05-26 07:38:38 UTC
logback-1.0.1-1.fc17 has been pushed to the Fedora 17 stable repository.

Comment 19 Fedora Update System 2012-05-29 10:30:00 UTC
logback-1.0.1-1.fc16 has been pushed to the Fedora 16 stable repository.


Note You need to log in before you can comment on or make changes to this bug.