Spec URL: http://www.grid.tsl.uu.se/review/voms-api-java.spec SRPM URL: http://www.grid.tsl.uu.se/review/voms-api-java-2.0.7-1.fc16.src.rpm Description: In grid computing, and whenever the access to resources may be controlled by parties external to the resource provider, users may be grouped to Virtual Organizations (VOs). This package provides a VO Membership Service (VOMS), which informs on that association between users and their VOs: groups, roles and capabilities. This package offers a java client API for VOMS. Note: With the update to version 2.0.7 of voms, the java API was moved to a separate source tree. So in order to be able to update voms to the latest version the new separate java package (i.e. this one) must be reviewed for Fedora so that the java api is not lost in the update.
I'll take this review
Good job, APPROVED review detail below. Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Buildroot is not needed unless packager plans to package for EPEL5 EPEL5 OK [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) EPEL5 OK Note: Clean is needed only if supporting EPEL [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files javadoc section. This is OK if packaging for EPEL5. Otherwise not needed [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [x]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint output is silent. rpmlint voms-api-java-2.0.7-1.fc18.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint voms-api-java-javadoc-2.0.7-1.fc18.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint voms-api-java-2.0.7-1.fc18.src.rpm voms-api-java.src: W: invalid-url Source0: voms-api-java-2.0.7.tar.gz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. OK [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. Package has no sources or they are generated by developer [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [-]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [-]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [-]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [ ]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: SHOULD Package should compile and build into binary rpms on all supported architectures. [ ]: SHOULD %check is present and all tests pass. [ ]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. [x] package build OK in mock [x] Sane obsoletes/provides for renamed/replaced packages [x] Java API documentation MUST be placed into a sub-package called %{name}-javadoc. [x] Single provided jar then filename %{name}.jar MUST be used. [x] All JAR files MUST go into %{_javadir} or a Java-version specific directory %{_javadir}-* as appropriate [x] Requires java, japackage-utils [x] Buildrequries java-devel. japackage-utils [x] maven3 packaging OK, Maven pom.xml files installed with the corresponding %add_maven_depmap calls. [x] ant packaging OK [-] Should wrapper script in %bindir [-] class-path elements removed from MANIFEST.MF
Many thanks for the review. New Package SCM Request ======================= Package Name: voms-api-java Short Description: Virtual Organization Membership Service Java API Owners: ellert Branches: f15 f16 f17 el5 el6 InitialCC:
Git done (by process-git-requests).
voms-2.0.7-2.fc17,voms-api-java-2.0.7-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/voms-2.0.7-2.fc17,voms-api-java-2.0.7-1.fc17
voms-2.0.7-2.el5,voms-api-java-2.0.7-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/voms-2.0.7-2.el5,voms-api-java-2.0.7-1.el5
voms-2.0.7-2.el6,voms-api-java-2.0.7-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/voms-2.0.7-2.el6,voms-api-java-2.0.7-1.el6
voms-2.0.7-2.fc16,voms-api-java-2.0.7-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/voms-2.0.7-2.fc16,voms-api-java-2.0.7-1.fc16
voms-2.0.7-2.fc15,voms-api-java-2.0.7-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/voms-2.0.7-2.fc15,voms-api-java-2.0.7-1.fc15
voms-2.0.7-2.el6, voms-api-java-2.0.7-1.el6 has been pushed to the Fedora EPEL 6 testing repository.
voms-2.0.7-2.fc17, voms-api-java-2.0.7-2.fc17 has been pushed to the Fedora 17 stable repository.
voms-2.0.7-2.fc15, voms-api-java-2.0.7-2.fc15 has been pushed to the Fedora 15 stable repository.
voms-2.0.7-2.fc16, voms-api-java-2.0.7-2.fc16 has been pushed to the Fedora 16 stable repository.
voms-2.0.7-2.el6, voms-api-java-2.0.7-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
voms-2.0.7-2.el5, voms-api-java-2.0.7-1.el5 has been pushed to the Fedora EPEL 5 stable repository.