Bug 80608 - gnome desktop leaks memory in the icon code
Summary: gnome desktop leaks memory in the icon code
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: gnome-desktop
Version: 8.0
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Brian Stein
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2002-12-28 17:31 UTC by Brian Stein
Modified: 2013-03-01 05:14 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2003-01-02 22:04:15 UTC


Attachments (Terms of Use)
leak fix (566 bytes, patch)
2002-12-28 17:32 UTC, Arjan van de Ven
no flags Details | Diff
another leak fixed (961 bytes, patch)
2002-12-28 17:40 UTC, Arjan van de Ven
no flags Details | Diff

Description Arjan van de Ven 2002-12-28 17:31:32 UTC
simple memory leak:
the icon filename gets replaced in the hashtable only conditional, but in case
the condition doesn't hit the memory for the pathname needs to be freed since
it's no longer used afterwards. Patch with fix attached.

Comment 1 Arjan van de Ven 2002-12-28 17:32:24 UTC
Created attachment 88965 [details]
leak fix

Comment 2 Arjan van de Ven 2002-12-28 17:40:03 UTC
Created attachment 88966 [details]
another leak fixed

The same file had another leak where a strdup()'d string didn't get freed in
one place; smaller leak (typical 6 bytes per time) but still...

Comment 3 Havoc Pennington 2003-01-02 22:04:15 UTC
Ah, looks fixed in CVS already. Should be fine in Rawhide (gnome-desktop 2.1.x, 
well the relevant files have moved to libgnomeui apparently)


Note You need to log in before you can comment on or make changes to this bug.