Spec URL: http://fedorapeople.org/~iarnell/review/perl-Data-Pond.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-Data-Pond-0.004-1.fc18.src.rpm Description: This module is concerned with representing data structures in a textual notation known as "Pond" (Perl-based open notation for data). The notation is a strict subset of Perl expression syntax, but is intended to have language- independent use. It is similar in spirit to JSON, which is based on JavaScript, but Pond represents fewer data types directly. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3930989 *rt-0.10_02
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [-]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [-]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [!]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint output is silent. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/contyk/src/review/806646/Data-Pond-0.004.tar.gz : MD5SUM this package : c295e60d95e1cd1d72e617541e9c326f MD5SUM upstream package : c295e60d95e1cd1d72e617541e9c326f [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [!]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX is a working URL. [ ]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [x]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [-]: SHOULD Spec use %global instead of %define. Issues: TODO: Don't require Exporter and Carp. Exporter is picked up automatically and Carp isn't actually used anywhere (just required by in Build.PL). Anyway, approving. I think I'll use this package in my own projects :) Generated by fedora-review 0.2.0git External plugins:
New Package SCM Request ======================= Package Name: perl-Data-Pond Short Description: Perl-based open notation for data Owners: iarnell Branches: f15 f16 f17 InitialCC: perl-sig
Git done (by process-git-requests).
(In reply to comment #1) > > Issues: > TODO: Don't require Exporter and Carp. Exporter is picked up automatically and > Carp isn't actually used anywhere (just required by in Build.PL). Ah, the Carp requirement seems to be left over from a previous version - it's only croaking from XS now. I've left Exporter as it's not picked up automatically outside rawhide.
perl-Data-Pond-0.004-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Data-Pond-0.004-2.fc16
perl-Data-Pond-0.004-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-Data-Pond-0.004-2.fc17
perl-Data-Pond-0.004-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Data-Pond-0.004-2.fc15
perl-Data-Pond-0.004-2.fc17 has been pushed to the Fedora 17 testing repository.
I've just noticed the explicit perl dependency on line 9. You might want to ditch in the next update.
Good catch - removed and updated in git repo.
perl-Data-Pond-0.004-2.fc15 has been pushed to the Fedora 15 stable repository.
perl-Data-Pond-0.004-2.fc16 has been pushed to the Fedora 16 stable repository.
perl-Data-Pond-0.004-2.fc17 has been pushed to the Fedora 17 stable repository.