Hide Forgot
Spec URL: http://brummbq.fedorapeople.org/kwooty.spec SRPM URL: http://brummbq.fedorapeople.org/kwooty-0.8.3-1.fc16.src.rpm Description: Kwooty is a NZB usenet binary downloader for KDE 4. Features : automatic file verification - repairing with par2 files, automatic archive extraction (Rar, Zip and 7z archive formats supported), built-in YEnc and UUEncode file decoders, ... atm I'm using version 0.8.3 - a non released version (contains various fixes) upstream send directly to me. I will upgrade as soon as possible.
Quick initial comment: 1. no need for a -devel pkg for a single lib symlink, with no headers or exported API (that I can tell). I'd recommend omitting that from packaging (via whatever method you prefer, like simply deleting it in %install or using %exclude).
> Requires: unrar is not a valid Requires, packages in Fedora must not depend on packages which are not in Fedora (and unrar is not, because it's non-Free).
(In reply to comment #2) > > Requires: unrar > is not a valid Requires, packages in Fedora must not depend on packages which > are not in Fedora (and unrar is not, because it's non-Free). yeah forgot to remove that. if the user want the automatic rar archive extraction he has to install unrar manually. the app recognizes on runtime if unrar is installed or not. The same applies to 7z and par2 except they are in fedora. I think kwooty should require at least par2 (par2cmdline)
So, in addition to stuff in comment #1 and comment #2 (lets consider that item 2), also: 3. MUST: Source0 not a full URL. (maybe because it's not referring to an official release... yet?). If so, please say so in a comment in the .spec naming: ok license: ok sources: NOT ok, cannot verify (see 3) macros: ok scriptlets: ok 4. MUST %files change %{_kde4_appsdir}/%{name}/* to %{_kde4_appsdir}/%{name}/ else the parent dir isn't properly owned So, fixup items 1-4, and I think we're good to go.
a new day a new kwooty. I think I addressed all your issues. Spec URL: http://brummbq.fedorapeople.org/kwooty.spec SRPM URL: http://brummbq.fedorapeople.org/kwooty-0.8.3-2.fc16.src.rpm (In reply to comment #4) > 3. MUST: Source0 not a full URL. (maybe because it's not referring to an > official release... yet?). If so, please say so in a comment in the .spec yep, it wasn't released...until today
looks good to me, all issues fixed. APPROVED.
New Package SCM Request ======================= Package Name: kwooty Short Description: A friendly nzb usenet binary download application Owners: brummbq Branches: f15 f16 f17 InitialCC:
Git done (by process-git-requests).
kwooty-0.8.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/kwooty-0.8.3-2.fc15
kwooty-0.8.3-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kwooty-0.8.3-2.fc16
kwooty-0.8.3-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kwooty-0.8.3-2.fc17
kwooty-0.8.3-2.fc16 has been pushed to the Fedora 16 testing repository.
kwooty-0.8.3-2.fc16 has been pushed to the Fedora 16 stable repository.
kwooty-0.8.3-2.fc15 has been pushed to the Fedora 15 stable repository.
kwooty-0.8.3-2.fc17 has been pushed to the Fedora 17 stable repository.
Package Change Request ====================== Package Name: kwooty New Branches: f21 Owners: rdieter
Complete.