Red Hat Bugzilla – Bug 81002
XMMS zz_mp3 minor fixup
Last modified: 2014-03-16 22:33:20 EDT
From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021218 Description of problem: XMMS currently has the zz_mp3 placeholder plugin that displays the patent error message when people try to play MP3's. Bug === When users install 3rd party MP3 plugins, this pop-up window continues to occur while they successfully play MP3's. Fix === These patches do the following: * If one or more of the MP3 Input plugins are installed and enabled, zz_mp3 will not pop up the warning window. * It recognizes the difference between an enabled and disabled plugin and acts accordingly. * It recognizes libmpg123.so and libxmmsmad.so. If you are aware of other possible MP3 input plugins for XMMS please e-mail me. Version-Release number of selected component (if applicable): Phoebe xmms-1.2.7-16.p
Created attachment 89084 [details] xmms-1.2.7-realmp3.patch Patch against xmms/pluginenum.c.
--- zz_mp3.c.orig 2002-12-31 02:50:10.000000000 -1000 +++ zz_mp3.c 2003-01-02 20:20:12.000000000 -1000 @@ -101,6 +101,7 @@ guint16 wavid; if (!enabled) return FALSE; + if(real_mp3_plugin()) return FALSE; if (!strncasecmp(filename, "http://", 7)) { /* We assume all http:// (except those ending in .ogg) are mpeg -- why do we do that? */
This shouldn't be needed; accroding to the xmms people, it should take the first plugin alphabetically that accepts the current file type.
According to my testing this isn't the case. Quite often BOTH plugins would "play" at the same time, playing the MP3 and popping up the Red Hat zz_mp3 window a the same time. I added some printf()'s to see the order, and zz_mp3 was engaging before libmpg123.so in every case.
Strange, in Phoebe2 only zz_mp3 would "play" while the installed MP3 plugin doesn't. Only when you disable zz_mp3 the installed MP3 plugin plays successfully.
Fixed differently in 1.2.7-19.p.
Confirmed, your fix seems to work perfectly.