Bug 810377 - Circular build dependency in perl-SQL-Statement-1.33-4.fc18
Summary: Circular build dependency in perl-SQL-Statement-1.33-4.fc18
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: perl-SQL-Statement
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-04-05 19:31 UTC by Paul Howarth
Modified: 2012-04-10 09:03 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-04-10 09:03:57 UTC
Type: Bug


Attachments (Terms of Use)

Description Paul Howarth 2012-04-05 19:31:03 UTC
perl-SQL-Statement has a buildreq of perl(DBD::CSV) >= 0.30, which is used in the
test suite if available. However, DBD::CSV itself buildrequires and requires SQL::Statement, so this creates a circular build dependency, which will be a problem when we come to build everything for perl 5.16. Suggested fix is to not buildrequire DBD::CSV when bootstrapping:

diff --git a/perl-SQL-Statement.spec b/perl-SQL-Statement.spec
index a5a8c64..2c1930f 100644
--- a/perl-SQL-Statement.spec
+++ b/perl-SQL-Statement.spec
@@ -17,7 +17,10 @@ BuildRequires:  perl(Clone) >= 0.30
 BuildRequires:  perl(Params::Util) >= 1.00
 # for tests only:
 BuildRequires:  perl(DBD::AnyData) >= 0.110
+# DBD::CSV buildrequires SQL::Statement
+%if 0%{!?perl_bootstrap:1}
 BuildRequires:  perl(DBD::CSV) >= 0.30
+%endif
 BuildRequires:  perl(DBD::DBM) >= 0.06
 BuildRequires:  perl(DBD::File) >= 0.40
 BuildRequires:  perl(DBD::SQLite)

Comment 1 Marcela Mašláňová 2012-04-06 12:19:55 UTC
Thanks. The patch looks fine.

Comment 2 Paul Howarth 2012-04-06 17:52:16 UTC
Unfortunately I missed another cycle here. DBD::AnyData also requires SQL::Statement and so needs to be avoided when bootstrapping:

diff --git a/perl-SQL-Statement.spec b/perl-SQL-Statement.spec
index c2448b5..9c967a2 100644
--- a/perl-SQL-Statement.spec
+++ b/perl-SQL-Statement.spec
@@ -16,9 +16,9 @@ BuildRequires:  perl(ExtUtils::MakeMaker)
 BuildRequires:  perl(Clone) >= 0.30
 BuildRequires:  perl(Params::Util) >= 1.00
 # for tests only:
-BuildRequires:  perl(DBD::AnyData) >= 0.110
-# DBD::CSV buildrequires SQL::Statement
+# DBD::AnyData and DBD::CSV require SQL::Statement
 %if 0%{!?perl_bootstrap:1}
+BuildRequires:  perl(DBD::AnyData) >= 0.110
 BuildRequires:  perl(DBD::CSV) >= 0.30
 %endif
 BuildRequires:  perl(DBD::DBM) >= 0.06

Comment 3 Marcela Mašláňová 2012-04-10 09:03:57 UTC
According to file Changes was DBD::AnyData removed, because it didn't work well. I removed it from BR. Test passed even without it.


Note You need to log in before you can comment on or make changes to this bug.