Spec URL: http://threebean.org/rpm/python-txzmq.spec SRPM URL: http://threebean.org/rpm/python-txzmq-0.3.1-1.fc16.src.rpm Description: txZMQ allows to integrate easily `ZeroMQ <http://zeromq.org>`_ sockets into Twisted event loop (reactor). koji-f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=3967084 koji-el6 - http://koji.fedoraproject.org/koji/taskinfo?taskID=3967086 rpmlint output: % rpmlint SPECS/python-txzmq.spec SRPMS/python-txzmq-0.3.1-1.fc16.src.rpm RPMS/noarch/python-txzmq-0.3.1-1.fc17.noarch.rpm python-txzmq.src: W: spelling-error %description -l en_US http -> HTTP python-txzmq.src: W: spelling-error %description -l en_US zeromq -> zero python-txzmq.noarch: W: spelling-error %description -l en_US http -> HTTP python-txzmq.noarch: W: spelling-error %description -l en_US zeromq -> zero
I will review this package
Package Review ============== Key: - = N/A x = Pass ! = Fail ? = Not evaluated ==== Generic ==== [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [x]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: MUST License field in the package spec file matches the actual license. [x]: MUST Package consistently uses macros (instead of hard-coded directory names). [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Requires correct, justified where necessary. [!]: MUST Rpmlint output is silent. rpmlint python-txzmq-0.3.1-1.fc17.noarch.rpm python-txzmq.noarch: W: spelling-error %description -l en_US http -> HTTP python-txzmq.noarch: W: spelling-error %description -l en_US zeromq -> zero 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint python-txzmq-0.3.1-1.fc17.src.rpm python-txzmq.src: W: spelling-error %description -l en_US http -> HTTP python-txzmq.src: W: spelling-error %description -l en_US zeromq -> zero 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. /home/haikel/810382/txZMQ-0.3.1.tar.gz : MD5SUM this package : 513bad68f9cfcee2076f4943e4156c80 MD5SUM upstream package : 513bad68f9cfcee2076f4943e4156c80 [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains a SysV-style init script if in need of one. [x]: MUST File names are valid UTF-8. [x]: MUST Useful -debuginfo package or justification otherwise. [x]: SHOULD Reviewer should test that the package builds in mock. [-]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [ ]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0: http://pypi.python.org/packages/source/t/txZMQ/txZMQ-0.3.1.tar.gz (txZMQ-0.3.1.tar.gz) Patch0: 0001-Corrected-FSF-address.patch (0001 -Corrected-FSF-address.patch) [x]: SHOULD SourceX is a working URL. [x]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [!]: SHOULD %check is present and all tests pass. [x]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define. Issues: [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files section. This is OK if packaging for EPEL5. Otherwise not needed See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions [!]: MUST Rpmlint output is silent. rpmlint python-txzmq-0.3.1-1.fc17.noarch.rpm python-txzmq.noarch: W: spelling-error %description -l en_US http -> HTTP python-txzmq.noarch: W: spelling-error %description -l en_US zeromq -> zero 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint python-txzmq-0.3.1-1.fc17.src.rpm python-txzmq.src: W: spelling-error %description -l en_US http -> HTTP python-txzmq.src: W: spelling-error %description -l en_US zeromq -> zero 1 packages and 0 specfiles checked; 0 errors, 2 warnings. See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint Generated by fedora-review 0.1.3 External plugins: * You should BR: python2-devel (that's what is required by python guidelines) * Unless you plan to support EPEL5, you should drop the %defattr macro * Since this package provides unit tests, you should at least execute them to check regressions (it's up to you to decide if a failing test should fail the build or not) adding BR: python-nose and running nosetests in %check section should do the trick Currently, the only failing test is due to zeromq package not built with epgm support (libpgm is not packaged and our guidelines forbid embedded libraries), you may check this issue with zeromq maintainer but this is not a blocker for this review Licensing is Ok (GPLv2), packaging only needs few correction to complies with fedora general and python specific guidelines, so it should be approved at the next iteration.
Updated the spec and SRPM. SPEC: http://threebean.org/rpm/python-txzmq.spec SRPM: http://threebean.org/rpm/python-txzmq-0.3.1-2.fc17.src.rpm - Changed BuildRequires python-devel to python2-devel. - Dropped the %defattr macro . - Patched to disable the EPGM test. libpgm isn't packaged for fedora yet. - Added %check section to run nosetests. The spelling errors coming from rpmlint are false positives, I think.
All valid points above are ok, the requested changes were done so i have no more reason to hold this review. I hereby approve this package into Fedora Packages Collection since it complies with all Fedora general and python specific guidelines.
New Package SCM Request ======================= Package Name: python-txzmq Short Description: Twisted bindings for ZeroMQ Owners: ralph Branches: f17 el6 InitialCC:
Git done (by process-git-requests).
python-txws-0.7-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-txws-0.7-3.el6
python-txzmq-0.3.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-txzmq-0.3.1-2.fc17
python-txzmq-0.3.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-txzmq-0.3.1-2.el6
python-txzmq-0.3.1-2.fc17 has been pushed to the Fedora 17 testing repository.
python-txzmq-0.3.1-2.fc17 has been pushed to the Fedora 17 stable repository.
python-txzmq-0.5.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-txzmq-0.5.0-1.el6
python-txzmq-0.5.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-txzmq-0.5.0-2.el6
python-txzmq-0.5.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.