Bug 810462 - TLS error messages overwriting in tlsm_verify_cert()
Summary: TLS error messages overwriting in tlsm_verify_cert()
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: openldap
Version: 16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Vcelak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 828787
TreeView+ depends on / blocked
 
Reported: 2012-04-06 09:16 UTC by Jan Vcelak
Modified: 2013-03-04 01:30 UTC (History)
6 users (show)

Fixed In Version: openldap-2.4.31-3.fc17
Clone Of:
: 828787 (view as bug list)
Environment:
Last Closed: 2012-07-17 17:21:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
proposed patch (1.42 KB, patch)
2012-05-28 12:18 UTC, Jan Vcelak
jvcelak: review?
Details | Diff

Description Jan Vcelak 2012-04-06 09:16:08 UTC
Description of problem:

Connecting to a server with self-signed certificate without basic constraint extension fails. This kind of error seems to stop connecting even if TLS_REQCERT=never is set.

Version-Release number of selected component (if applicable):
openldap-2.4.26-7.fc16


How reproducible:


Steps to Reproduce:
1.
generate self-signed server certificate with:
certutil -d . -S -x -n ldap -s "CN=server" -t TC,,
2.
setup permissions, setup slapd, setup client
3.
ldapsearch -x -ZZ -H ldap://server
  
Actual results:

TLS: certificate [CN=server] is not valid - CA cert is not valid
TLS: certificate [CN=server] is not valid - error -8172:Peer's certificate issuer has been marked as not trusted by the user..
TLS: error: connect - force handshake failure: errno 21 - moznss error -8157
TLS: can't connect: TLS error -8157:Certificate extension not found..
ldap_err2string
ldap_start_tls: Connect error (-11)
        additional info: TLS error -8157:Certificate extension not found.


Expected results:

successful connection


Additional info:

Comment 1 Jan Vcelak 2012-04-26 08:11:59 UTC
This is not right. My configuration was wrong, no certificates were available. But the error message is wrong, it is completely unrelated to the problem which happened.

The original error can was overwritten with the error from the report in tlsm_verify_cert(). While walking through the verification log, basic extension from the certificate is requested in case there is a SEC_ERROR_CA_CERT_INVALID error. If the extension is not a part of the certificate, the original error is overwritten.

PR_GetError() and PR_SetError() should fix that.

Comment 2 Jan Vcelak 2012-05-28 12:18:50 UTC
Created attachment 587230 [details]
proposed patch

Broken version:

$ ldapsearch -x -ZZ
ldap_start_tls: Connect error (-11)
        additional info: TLS error -8157:Certificate extension not found.

Fixed version:

$ ../_build/clients/tools/ldapsearch -x -ZZ
ldap_start_tls: Connect error (-11)
        additional info: TLS error -8172:Peer's certificate issuer has been marked as not trusted by the user.

Comment 3 Jan Vcelak 2012-05-28 12:21:43 UTC
The patch fixes the issue with LDAPTLS_REQCERT=never as well.

Comment 4 Jan Vcelak 2012-06-05 09:54:31 UTC
Submitted upstream:
http://www.openldap.org/its/index.cgi?findid=7287

Comment 5 Jan Vcelak 2012-06-05 11:36:48 UTC
Committed upstream:
http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=commit;h=dc3842f

Comment 6 Jan Vcelak 2012-06-27 13:11:59 UTC
Resolved in openldap-2.4.31-3.fc17

Comment 7 Fedora Update System 2012-06-27 13:17:01 UTC
openldap-2.4.31-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/openldap-2.4.31-3.fc17

Comment 8 Fedora Update System 2012-06-27 16:06:13 UTC
openldap-2.4.26-8.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/openldap-2.4.26-8.fc16

Comment 9 Fedora Update System 2012-06-28 03:32:58 UTC
Package openldap-2.4.31-3.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing openldap-2.4.31-3.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-10000/openldap-2.4.31-3.fc17
then log in and leave karma (feedback).

Comment 10 Fedora Update System 2012-07-17 17:21:50 UTC
openldap-2.4.31-3.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2012-07-17 17:26:28 UTC
openldap-2.4.26-8.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Julian C. Dunn 2012-10-02 19:10:52 UTC
This seems to afflict the current version of openldap in RHEL 6 as well. Is there a related bug for that?

Comment 13 Jan Vcelak 2012-10-03 07:27:10 UTC
(In reply to comment #12)
> This seems to afflict the current version of openldap in RHEL 6 as well. Is
> there a related bug for that?

Yes, there is - bug #828787, you will need to wait for RHEL-6.4


Note You need to log in before you can comment on or make changes to this bug.