Bug 810851 - fix broken %if 0%{?fedora} conditionals
Summary: fix broken %if 0%{?fedora} conditionals
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: NetworkManager
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dan Williams
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-04-09 12:02 UTC by Daniel Mach
Modified: 2012-04-10 07:54 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-04-10 07:54:35 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)

Description Daniel Mach 2012-04-09 12:02:42 UTC 
If the "fedora" macro is not defined, then
0%{?fedora} < 17
is always true.

This leads to broken builds when building the package in different environments.
A good practice is to test if %fedora is set and only then proceed with the version comparison.

Can you apply following change to spec?
(there are 2 occurences of this problem):
-%if 0%{?fedora} < 17
+%if 0%{?fedora} && 0%{?fedora} < 17
Comment 1 Jirka Klimes 2012-04-10 07:54:35 UTC 
Fixed both in rawhide and F17.
Thanks.
Note You need to log in before you can comment on or make changes to this bug.