Red Hat Bugzilla – Bug 811053
Stop using "shell=True" when invoking the subprocess module
Last modified: 2012-04-10 02:12:33 EDT
To eliminate some early compatibility problems with the rsync invocation, the current subprocess invocation code relies on the system shell to parse the created rsync command line.
The test suite is now sufficiently comprehensive that this workaround should be eliminated - it was an acceptable quick fix to avoid stalling development, but needs to be eliminated before the code can be considered ready for deployment.
Fixed for 0.0.11
It turned out some arguments were already being manually quoted, which were then getting quoted *again* by the subprocess module when using "shell=False". This then confused rsync, which refused to run due to unrecognised filtering commands. Removing the manual quoting and relying entirely on the automatic quoting appears to have resolved the problem.