Bug 811750 - Review Request: python-tw2-jqplugins-gritter - jQuery gritter (growl-like popups) for ToscaWidgets2
Review Request: python-tw2-jqplugins-gritter - jQuery gritter (growl-like pop...
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Michel Alexandre Salim
Fedora Extras Quality Assurance
:
Depends On: 811739
Blocks: 818293
  Show dependency treegraph
 
Reported: 2012-04-11 17:29 EDT by Ralph Bean
Modified: 2014-11-12 17:09 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-05-26 03:30:33 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
michel: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Ralph Bean 2012-04-11 17:29:17 EDT
Spec URL: http://threebean.org/rpm/python-tw2-jqplugins-gritter.spec
SRPM URL: http://threebean.org/rpm/python-tw2-jqplugins-gritter-2.0.0-1.fc17.src.rpm
Description:
This module provides growl like popups with the gritter plugin for
python-tw2-jqplugins-ui.

----

This module depends on python-tw2-jqplugins-ui which is currently up for review - https://bugzilla.redhat.com/show_bug.cgi?id=811739
Comment 1 Ralph Bean 2012-05-02 19:18:04 EDT
Spec URL: http://threebean.org/rpm/python-tw2-jqplugins-gritter.spec
SRPM URL: http://threebean.org/rpm/python-tw2-jqplugins-gritter-2.0.1-1.fc17.src.rpm

New upstream release that includes the LICENSE.
Comment 2 Ralph Bean 2012-05-03 09:12:20 EDT
A question came up in #fedora-devel as to whether or not we can bundle javascript intended to be served by a web app.  There is an explicit exemption in the packaging guidelines making this "OK".

http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries
Comment 3 Michel Alexandre Salim 2012-05-04 06:19:49 EDT
Taking this review and #812059; could you swap with https://bugzilla.redhat.com/show_bug.cgi?id=787193  ? Thanks!
Comment 4 Ralph Bean 2012-05-04 11:16:25 EDT
Sure thing!  I've taken it.
Comment 5 Michel Alexandre Salim 2012-05-05 01:58:08 EDT
Thanks! Starting the review by installing the required tw2 packages by hand into my local mock.

rpmlint output:
python-tw2-jqplugins-gritter-2.0.1-1.fc17.src.rpm:

python-tw2-jqplugins-gritter.src: W: spelling-error Summary(en_US) jQuery -> j Query, query, equerry
python-tw2-jqplugins-gritter.src: W: summary-not-capitalized C jQuery gritter (growl-like pop-ups) for ToscaWidgets2
python-tw2-jqplugins-gritter.src: W: spelling-error %description -l en_US ui -> ii, u, i
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


python-tw2-jqplugins-gritter-2.0.1-1.fc17.noarch.rpm:
python-tw2-jqplugins-gritter.noarch: W: spelling-error Summary(en_US) jQuery -> j Query, query, equerry
python-tw2-jqplugins-gritter.noarch: W: summary-not-capitalized C jQuery gritter (growl-like pop-ups) for ToscaWidgets2
python-tw2-jqplugins-gritter.noarch: W: spelling-error %description -l en_US ui -> ii, u, i
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

All are harmless spelling false-positives.

Regarding the bundled javascript -- is that in the main tw2-jquery package? I don't see any file in -gritter that seems to belong to another already-shipped package.
 
Review checklist below. Note the comment on macro (though that's not important), but more importantly, directory ownership

* TODO Review [90%]
  - [X] Names [2/2]
    - [X] Package name
    - [X] Spec name
  - [X] Package version [2/2]
	http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Versioning
    - [X] Version number
	  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Version_Tag
    - [X] Release tag
	  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Release_Tag
	  http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
  - [X] Meets [[http://fedoraproject.org/wiki/Packaging/Guidelines][guidelines]]
  - [X] Source files match upstream
    sha256sum ./tw2.jqplugins.gritter-2.0.1.tar.gz ~/rpmbuild/SOURCES/tw2.jqplugins.gritter-2.0.1.tar.gz 
  7491cf18380010c1cbc6008769a07897f0f301b3135050172aabdfb37dad4adf  ./tw2.jqplugins.gritter-2.0.1.tar.gz
  7491cf18380010c1cbc6008769a07897f0f301b3135050172aabdfb37dad4adf  /home/michel/rpmbuild/SOURCES/tw2.jqplugins.gritter-2.0.1.tar.gz
  - [X] [[http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries][No bundled libraries]]
  - [X] License [4/4]
    - [X] License is Fedora-approved
    - [X] No licensing conflict
    - [X] License field accurate
    - [X] License included iff packaged by upstream
  - [X] rpmlint [2/2]
    - [X] on src.rpm
    - [X] on x86_64.rpm
  - [X] Language & locale [2/2]
    - [X] Spec in US English
    - [X] Spec legible
  - [-] Build [2/3]
    - [X] Koji results
      local mock in lieue of Koji
    - [X] BRs complete
    - [ ] Directory ownership
      The wildcard makes this package also owns the following, which
      should be owned by packages it depend on:
      %{python_sitelib}/tw2
      %{python_sitelib}/tw2/jqplugins

      Perhaps change this to:
      %{python_sitelib}/tw2.jqplugins.gritter*
      %{python_sitelib}/tw2/jqplugins/gritter

  - [X] Spec inspection [5/5]
    - [X] No duplicate files
    - [X] File permissions
    - [X] Filenames must be UTF-8
    - [X] no BuildRoot ([[https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag][except if targeting RHEL5]])
    - [X] Macro usage consistent
      note that you can just use 0%{?rhel} rather than
      %{?rhel}%{!?rhel:0}
Comment 6 Ralph Bean 2012-05-07 13:26:47 EDT
Here's a new release that (hopefully) fixes the directory ownership issue you pointed out.

I left the rhel macro as-is to maintain consistency across the python-tw2-* packages.  Thanks for the tip, though!  :)

Spec URL: http://threebean.org/rpm/python-tw2-jqplugins-gritter.spec
SRPM URL: http://threebean.org/rpm/python-tw2-jqplugins-gritter-2.0.1-2.fc17.src.rpm
Comment 7 Michel Alexandre Salim 2012-05-08 06:41:38 EDT
Looks good -- APPROVED
Comment 8 Ralph Bean 2012-05-08 17:15:55 EDT
New Package SCM Request
=======================
Package Name: python-tw2-jqplugins-gritter
Short Description: jQuery gritter (growl-like popups) for ToscaWidgets2
Owners: ralph
Branches: f17 el6
InitialCC:
Comment 9 Jon Ciesla 2012-05-09 08:31:08 EDT
Git done (by process-git-requests).
Comment 10 Fedora Update System 2012-05-09 14:55:39 EDT
python-tw2-jqplugins-gritter-2.0.1-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-tw2-jqplugins-gritter-2.0.1-2.fc17
Comment 11 Fedora Update System 2012-05-09 15:06:03 EDT
python-tw2-jqplugins-gritter-2.0.1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-tw2-jqplugins-gritter-2.0.1-2.el6
Comment 12 Fedora Update System 2012-05-10 16:38:23 EDT
python-tw2-jqplugins-gritter-2.0.1-2.fc17 has been pushed to the Fedora 17 testing repository.
Comment 13 Fedora Update System 2012-05-26 03:30:33 EDT
python-tw2-jqplugins-gritter-2.0.1-2.fc17 has been pushed to the Fedora 17 stable repository.
Comment 14 Fedora Update System 2012-05-26 18:08:07 EDT
python-tw2-jqplugins-gritter-2.0.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Comment 15 Ralph Bean 2014-11-12 15:25:09 EST
Package Change Request
======================
Package Name: python-tw2-jqplugins-gritter
New Branches: epel7
Owners: ralph
InitialCC:
Comment 16 Jon Ciesla 2014-11-12 17:09:20 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.