RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 811814 - live snapshot and mirroring should check whether target image is current one
Summary: live snapshot and mirroring should check whether target image is current one
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: qemu-kvm
Version: 6.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Jeff Cody
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 809140
Blocks: 806280
TreeView+ depends on / blocked
 
Reported: 2012-04-12 03:21 UTC by Shaolong Hu
Modified: 2013-06-03 17:54 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-06-03 17:54:49 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Shaolong Hu 2012-04-12 03:21:17 UTC 
Description of problem:
------------------------
live snapshot and mirroring operation should check whether target image is current one.

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
qemu-kvm 272

How reproducible:
------------------
100%

Steps to Reproduce:
--------------------
1. when live snapshot or mirroring, if target is current image using by the block device, they simply over write it instead of prompt error.

(qemu) info block
drive-virtio-disk0: removable=0 io-status=ok file=RHEL-Server-6.3-64-virtio.qcow2 ro=0 drv=qcow2 encrypted=0

(qemu) snapshot_blkdev drive-virtio-disk0 /root/RHEL-Server-6.3-64-virtio.qcow2


Expected results:
-------------------
prompt error and refuse to do so.
Comment 2 Jeff Cody 2012-04-12 19:53:06 UTC 
Since we won't know if the path leading up to the snapshot filename matches exactly that path used to open the image, this will likely require something like realpath() or qemu_file_get_full_path(), so that we can compare absolute canonical filenames of all open images against the new proposed image filename.  Bug #809140 will likely bring qemu_file_get_full_path() in, so I am marking this dependent on that bug.

But even with a canonical absolute path, I don't think that gives us 100% protection - the file could still be located on a mounted network filesystem, under a different directory, etc. With that in mind, I am wondering if this is a bug we fix in the QEMU layer, or something that is on the management layer to be aware of (i.e. don't use an existing / open image).
Comment 5 RHEL Program Management 2012-07-10 06:46:44 UTC 
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.
Comment 6 RHEL Program Management 2012-07-11 02:05:54 UTC 
This request was erroneously removed from consideration in Red Hat Enterprise Linux 6.4, which is currently under development.  This request will be evaluated for inclusion in Red Hat Enterprise Linux 6.4.
Comment 7 Ademar Reis 2012-07-25 14:18:51 UTC 
Due to limited capacity, we won't be able to work on this in RHEL6.4. Deferring to 6.5 (high chances of closing this as WONTFIX in the next cycle).
Comment 9 Ademar Reis 2013-06-03 17:54:49 UTC 
(In reply to Ademar de Souza Reis Jr. from comment #7)
> Due to limited capacity, we won't be able to work on this in RHEL6.4.
> Deferring to 6.5 (high chances of closing this as WONTFIX in the next cycle).

Keeping my promisse...
Note You need to log in before you can comment on or make changes to this bug.