Spec URL: http://hobbes1069.fedorapeople.org/zipios/zipios++.spec SRPM URL: http://hobbes1069.fedorapeople.org/zipios/zipios++-0.1.5.9-5.fc16.src.rpm Description: Zipios++ is a java.util.zip-like C++ library for reading and writing Zip files. Access to individual entries is provided through standard C++ iostreams. A simple read-only virtual file system that mounts regular directories and zip files is also provided. rpmlint output: $ rpmlint SRPMS/zipios++-0.1.5.9-5.fc16.src.rpm zipios++.src: I: enchant-dictionary-not-found pl.UTF-8 zipios++.src: W: spelling-error %description -l en_US Zipios -> Scipio zipios++.src: W: spelling-error %description -l en_US util -> til, until, u til zipios++.src: W: spelling-error %description -l en_US iostreams -> mainstreams, streams 1 packages and 0 specfiles checked; 0 errors, 3 warnings. rpmlint output of installed package # rpmlint zipios++ zipios++.x86_64: I: enchant-dictionary-not-found pl.UTF-8 zipios++.x86_64: W: spelling-error %description -l en_US Zipios -> Scipio zipios++.x86_64: W: spelling-error %description -l en_US util -> til, until, u til zipios++.x86_64: W: spelling-error %description -l en_US iostreams -> mainstreams, streams zipios++.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzipios.so.0.0.0 linux-vdso.so.1 zipios++.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libzipios.so.0.0.0 /lib64/libm.so.6 1 packages and 0 specfiles checked; 0 errors, 5 warnings.
I'll give this a go.
Good: - rpmlint checks return: zipios++.x86_64: I: enchant-dictionary-not-found pl.UTF-8 A dictionary for the Enchant spell checking library is not available for the language given in the info message. Spell checking will proceed with rpmlint's built-in implementation for localized tags in this language. For better spell checking results in this language, install the appropriate dictionary that Enchant will use for this language, often for example hunspell-* or aspell-*. Fix. zipios++.x86_64: W: spurious-executable-perm /usr/share/doc/zipios++-0.1.5.9/COPYING The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. Fix. And several ignorable spelling errors. - package meets naming guidelines - package meets packaging guidelines - license ( LGPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english I cannot speak to the accuracy of the Polish, I should ask my dad. . . - source matches upstream N/A - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok N/A - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Otherwise OK. So it's just the rpmlint stuff. I assume the only reason you're packaging software with no current upstream is as a dependency?
(In reply to comment #2) > Good: > > - rpmlint checks return: > > zipios++.x86_64: I: enchant-dictionary-not-found pl.UTF-8 > A dictionary for the Enchant spell checking library is not available for the > language given in the info message. Spell checking will proceed with > rpmlint's built-in implementation for localized tags in this language. For > better spell checking results in this language, install the appropriate > dictionary that Enchant will use for this language, often for example > hunspell-* or aspell-*. > > Fix. I looked into this, I think this is just telling you that it can't check the spelling because you don't have a Polish dictionary installed. At least this is my interpretation of the error. > zipios++.x86_64: W: spurious-executable-perm > /usr/share/doc/zipios++-0.1.5.9/COPYING > The file is installed with executable permissions, but was identified as one > that probably should not be executable. Verify if the executable bits are > desired, and remove if not. > > Fix. Oops. I had that fixed locally. Must have fixed it after I copied my stuff to fedorapeople.org. Fixed. > I cannot speak to the accuracy of the Polish, I should ask my dad. . . It was in the package I started with and I didn't see any reason to remove it :) > Otherwise OK. So it's just the rpmlint stuff. I assume the only reason you're > packaging software with no current upstream is as a dependency? Yup. It's bundled in FreeCAD. Spec URL: http://hobbes1069.fedorapeople.org/zipios/zipios++.spec SRPM URL: http://hobbes1069.fedorapeople.org/zipios/zipios++-0.1.5.9-6.fc16.src.rpm Thanks, Richard
Yup, I installed hunspell-pl and it complains about the polish spelling as well. :) Looks great now. APPROVED.
Thanks for the review. Let me know if you need one sometime later.
New Package SCM Request ======================= Package Name: zipios++ Short Description: C++ library for reading and writing Zip files Owners: hobbes1069 Branches: f16 f17 InitialCC:
Anytime. I don't have any right now, but you could do a Merge Review. :)
Git done (by process-git-requests).
zipios++-0.1.5.9-6.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/zipios++-0.1.5.9-6.fc16
zipios++-0.1.5.9-6.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/zipios++-0.1.5.9-6.fc17
zipios++-0.1.5.9-6.fc17 has been pushed to the Fedora 17 testing repository.
zipios++-0.1.5.9-6.fc17 has been pushed to the Fedora 17 stable repository.
zipios++-0.1.5.9-6.fc16 has been pushed to the Fedora 16 stable repository.
Package Change Request ====================== Package Name: zipios++ New Branches: el6 Owners: zultron hobbes1069 InitialCC: The owner of this package (hobbes1069) and I (zultron) are building this package for EPEL6.
Package Change Request ====================== Package Name: zipios++ New Branches: epel7 Owners: hobbes1069 InitialCC: