Hide Forgot
Spec URL: http://petersen.fedorapeople.org/reviews/ghc-blaze-builder-conduit/ghc-blaze-builder-conduit.spec SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-blaze-builder-conduit/ghc-blaze-builder-conduit-0.3.0-1.fc16.src.rpm Description: Converts a stream of blaze-builder Builders into a stream of ByteStrings f18 koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3993146 This is needed for wai-extra and warp (and hence yesod). Will update to 0.4.* once we can build conduit-0.4 in rawhide.
[+]MUST: rpmlint must be run on every package. The output should be posted in the review. ghc-blaze-builder-conduit.src: W: spelling-error Summary(en_US) bytestring -> byte string, byte-string, restringing The value of this tag appears to be misspelled. Please double-check. ghc-blaze-builder-conduit.src: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona The value of this tag appears to be misspelled. Please double-check. ghc-blaze-builder-conduit.x86_64: W: spelling-error Summary(en_US) bytestring -> byte string, byte-string, restringing The value of this tag appears to be misspelled. Please double-check. ghc-blaze-builder-conduit.x86_64: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona The value of this tag appears to be misspelled. Please double-check. ghc-blaze-builder-conduit-devel.x86_64: W: spelling-error Summary(en_US) bytestring -> byte string, byte-string, restringing The value of this tag appears to be misspelled. Please double-check. ghc-blaze-builder-conduit-devel.x86_64: W: spelling-error %description -l en_US monad -> nomad, gonad, Mona The value of this tag appears to be misspelled. Please double-check. 3 packages and 1 specfiles checked; 0 errors, 6 warnings. [+]MUST: The package must be named according to the Package Naming Guidelines. [+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec [+]MUST: The package must meet the Packaging Guidelines. Naming-Yes Version-release - Matches No prebuilt external bits - OK Spec legibity - OK Package template - OK Arch support - OK Libexecdir - OK rpmlint - yes changelogs - OK Source url tag - OK, validated. Build Requires list - OK Summary and description - OK API documentation - OK, in devel package. [+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. BSD license. [+]MUST: The License field in the package spec file must match the actual license. [+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. LICENSE file is included. [+]MUST: The spec file must be written in American English. [+]MUST: The spec file for the package MUST be legible. [+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task. md5sum blaze-builder-conduit-0.3.0.tar.gz 56708a17c1257236a5725c615146bcae blaze-builder-conduit-0.3.0.tar.gz md5sum ghc-blaze-builder-conduit-0.3.0-1.fc16.src/blaze-builder-conduit-0.3.0.tar.gz 56708a17c1257236a5725c615146bcae ghc-blaze-builder-conduit-0.3.0-1.fc16.src/blaze-builder-conduit-0.3.0.tar.gz [+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. Built on x86_64. [+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. [+]MUST: All build dependencies must be listed in BuildRequires. [+]MUST: Packages must NOT bundle copies of system libraries. Checked with rpmquery --list [NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review. [+]MUST: A package must own all directories that it creates. Checked with rpmquery --whatprovides [+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [+]MUST: Permissions on files must be set properly. Checked with ls -lR. [+]MUST: Each package must consistently use macros. [+]MUST: The package must contain code, or permissible content. [+]MUST: Large documentation files must go in a -doc subpackage. [+]MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release} [+]MUST: Packages must not own files or directories already owned by other packages. [+]MUST: All filenames in rpm packages must be valid UTF-8. Should items [+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. LICENSE file is included. [+]SHOULD: The reviewer should test that the package functions as described. Installed the packages. Loaded Data.Conduit.Blaze into ghci. Loads fine. [+]SHOULD: If scriptlets are used, those scriptlets must be sane. cabal2spec-diff is OK. APPROVED.
Thank you very much for reviewing. New Package SCM Request ======================= Package Name: ghc-blaze-builder-conduit Short Description: Convert builder streams to bytestring streams Owners: petersen Branches: f17 f16 el6 InitialCC: haskell-sig
Git done (by process-git-requests).
Built for f18 rawhide. f17 is still on conduit-0.2 and I will probably just update it straight to 0.4 once ghc-void is available so waiting for now with the branches.
ghc-blaze-builder-conduit-0.4.0.1-1.fc17,ghc-conduit-0.4.1.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ghc-blaze-builder-conduit-0.4.0.1-1.fc17,ghc-conduit-0.4.1.1-1.fc17
ghc-blaze-builder-conduit-0.4.0.1-1.fc17, ghc-conduit-0.4.1.1-1.fc17 has been pushed to the Fedora 17 testing repository.
ghc-void-0.5.5.1-1.fc17, ghc-conduit-0.4.1.1-2.fc17, ghc-blaze-builder-conduit-0.4.0.1-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ghc-void-0.5.5.1-1.fc17,ghc-conduit-0.4.1.1-2.fc17,ghc-blaze-builder-conduit-0.4.0.1-2.fc17
ghc-void-0.5.5.1-1.fc17, ghc-conduit-0.4.1.1-2.fc17, ghc-blaze-builder-conduit-0.4.0.1-2.fc17 has been pushed to the Fedora 17 testing repository.
ghc-void-0.5.5.1-1.fc17, ghc-conduit-0.4.1.1-2.fc17, ghc-blaze-builder-conduit-0.4.0.1-2.fc17 has been pushed to the Fedora 17 stable repository.