Bug 812699 - Review Request: ghc-happstack-server - Happstack web framework
Review Request: ghc-happstack-server - Happstack web framework
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Narasimhan
Fedora Extras Quality Assurance
Depends On: ghc-sendfile
  Show dependency treegraph
Reported: 2012-04-15 22:10 EDT by Jens Petersen
Modified: 2012-05-27 03:25 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-05-26 03:16:35 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
lakshminaras2002: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Jens Petersen 2012-04-15 22:10:44 EDT
Spec URL: http://petersen.fedorapeople.org/reviews/ghc-happstack-server/ghc-happstack-server.spec
SRPM URL: http://petersen.fedorapeople.org/reviews/ghc-happstack-server/ghc-happstack-server-7.0.0-1.fc16.src.rpm
Description: Happstack Server provides an HTTP server and a rich set of functions for routing requests, handling query parameters, generating responses, working with cookies, serving files, etc.

See http://happstack.com/

Note this is pending the ghc-sendfile review:
Comment 1 Jens Petersen 2012-05-06 23:19:21 EDT
7.0.1 needs system-filepath - I will submit it later.

Here is a updated package which actually builds correctly
(this package seem to assume base3 by default...)

Spec: http://petersen.fedorapeople.org/reviews/ghc-happstack-server/ghc-happstack-server.spec
SRPM: http://petersen.fedorapeople.org/reviews/ghc-happstack-server/ghc-happstack-server-7.0.0-2.fc16.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4058763
Comment 2 Narasimhan 2012-05-11 22:48:46 EDT
[+]MUST: rpmlint must be run on every package. The output should be posted in the review.

 rpmlint  -i ghc-happstack-server-7.0.0-2.fc15.x86_64.rpm ghc-happstack-server-7.0.0-2.fc15.src.rpm c-happstack-server-devel-7.0.0-2.fc15.x86_64.rpm ../ghc-happstack-server.spec 
3 packages and 1 specfiles checked; 0 errors, 0 warnings.

[+]MUST: The package must be named according to the Package Naming Guidelines.
[+]MUST: The spec file name must match the base package %{name}, in the format %{name}.spec
[+]MUST: The package must meet the Packaging Guidelines.
        Version-release - Matches
        No prebuilt external bits - OK
        Spec legibity - OK
        Package template - OK
        Arch support - OK
        Libexecdir - OK
        rpmlint - yes
        changelogs - OK
        Source url tag  - OK, validated.
        Build Requires list - OK
        Summary and description - OK
        API documentation - OK, in devel package

[+]MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
[+]MUST: The License field in the package spec file must match the actual license.
[+]MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
COPYING file is included.
[+]MUST: The spec file must be written in American English.
[+]MUST: The spec file for the package MUST be legible.
[+]MUST: The sources used to build the package must match the upstream source,as provided in the spec URL. Reviewers should use md5sum for this task.
md5sum happstack-server-7.0.0.tar.gz 
ade8cc2a071293515a1d2c85e63f71ad  happstack-server-7.0.0.tar.gz

md5sum ghc-happstack-server-7.0.0-2.fc16.src/happstack-server-7.0.0.tar.gz 
ade8cc2a071293515a1d2c85e63f71ad  ghc-happstack-server-7.0.0-2.fc16.src/happstack-server-7.0.0.tar.gz

[+]MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
Built on x86_64.
[+]MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch.
[+]MUST: All build dependencies must be listed in BuildRequires.
[+]MUST: Packages must NOT bundle copies of system libraries.
Checked with rpmquery --list
[NA]MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review.
[+]MUST: A package must own all directories that it creates.
Checked with rpmquery --whatprovides
[+]MUST: A Fedora package must not list a file more than once in the spec file's %files listings.
[+]MUST: Permissions on files must be set properly.
Checked with ls -lR
[+]MUST: Each package must consistently use macros.
[+]MUST: The package must contain code, or permissible content.
[+]MUST: Large documentation files must go in a -doc subpackage.
[+]MUST: If a package includes something as %doc, it must not affect the runtime of the application.
[+]MUST: devel packages must require the base package using a fully versioned dependency: Requires: {name} = %{version}-%{release}
rpm -e ghc-happstack-server-7.0.0-2.fc15.x86_64
error: Failed dependencies:
        ghc(happstack-server-7.0.0) = f7323346b0a87d6b48cb7a077c669b99 is needed by (installed) ghc-happstack-server-devel-7.0.0-2.fc15.x86_64
        ghc-happstack-server = 7.0.0-2.fc15 is needed by (installed) ghc-happstack-server-devel-7.0.0-2.fc15.x86_64
[+]MUST: Packages must not own files or directories already owned by other packages.
[+]MUST: All filenames in rpm packages must be valid UTF-8.

Should items
[+]SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[+]SHOULD: The reviewer should test that the package functions as described.
Installs fine. Loaded Happstack.Server.Client into ghci. Loads fine.
[+]SHOULD: If scriptlets are used, those scriptlets must be sane.

cabal2spec-diff is OK.

Comment 3 Jens Petersen 2012-05-13 22:19:55 EDT
New Package SCM Request
Package Name: ghc-happstack-server
Short Description: Happstack web framework
Owners: petersen
Branches: f17 f16 el6 f15
InitialCC: haskell-sig
Comment 4 Gwyn Ciesla 2012-05-14 08:10:59 EDT
Git done (by process-git-requests).
Comment 5 Fedora Update System 2012-05-14 22:28:10 EDT
ghc-sendfile-0.7.6-1.fc17, ghc-happstack-server-7.0.0-2.fc17 has been submitted as an update for Fedora 17.
Comment 6 Fedora Update System 2012-05-14 23:00:11 EDT
ghc-sendfile-0.7.6-1.fc16, ghc-happstack-server-7.0.0-2.fc16 has been submitted as an update for Fedora 16.
Comment 7 Fedora Update System 2012-05-15 00:59:14 EDT
ghc-sendfile-0.7.6-1.fc15, ghc-happstack-server-7.0.0-2.fc15 has been submitted as an update for Fedora 15.
Comment 8 Fedora Update System 2012-05-15 12:40:55 EDT
ghc-sendfile-0.7.6-1.fc17, ghc-happstack-server-7.0.0-2.fc17 has been pushed to the Fedora 17 testing repository.
Comment 9 Fedora Update System 2012-05-26 03:16:35 EDT
ghc-sendfile-0.7.6-1.fc17, ghc-happstack-server-7.0.0-2.fc17 has been pushed to the Fedora 17 stable repository.
Comment 10 Fedora Update System 2012-05-26 21:57:13 EDT
ghc-sendfile-0.7.6-1.fc16, ghc-happstack-server-7.0.0-2.fc16 has been pushed to the Fedora 16 stable repository.
Comment 11 Fedora Update System 2012-05-27 03:25:10 EDT
ghc-sendfile-0.7.6-1.fc15, ghc-happstack-server-7.0.0-2.fc15 has been pushed to the Fedora 15 stable repository.

Note You need to log in before you can comment on or make changes to this bug.