Bug 813648 - gnome-shell shows blank windows on hardware lacking NPOT textures
Summary: gnome-shell shows blank windows on hardware lacking NPOT textures
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cogl
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedBlocker
: 797025 (view as bug list)
Depends On:
Blocks: F17Blocker, F17FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2012-04-18 06:23 UTC by Ben Skeggs
Modified: 2012-05-16 16:34 UTC (History)
10 users (show)

Fixed In Version: mutter-3.4.1-3.fc17
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-15 05:25:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Ben Skeggs 2012-04-18 06:23:17 UTC
Description of problem:

GeForce FX (and below) hardware has no support for full GL_ARB_texture_non_power_of_two.  gnome-shell/clutter/cogl (whatever's responsible) used to handle things correctly just using GL_ARB_texture_rectangle, but apparently this got broken some time between F16 and F17.

Version-Release number of selected component (if applicable):

How reproducible:
Always, if you have the "right" hardware.

Steps to Reproduce:
1. Have a GeForce FX or below GPU
2. Try to use gnome-shell in F17

or

1. Be using F17
2. gnome-shell --cogl-debug=disable-npot-textures --replace
  
Actual results:
Windows don't have their contents.

Expected results:
Windows show their contents.

Additional info:

Comment 1 Dave Airlie 2012-05-02 09:22:52 UTC
http://git.gnome.org/browse/cogl/tree/cogl/cogl-primitives.c#n556

is where we saw this going wrong before.

cogl would end up picking the 0 layer which was the shadow not the first layer which was the window contents.

Comment 2 Adam Jackson 2012-05-02 17:39:15 UTC
#clutter suggests this bit of mutter might be apropos:

http://git.gnome.org/browse/mutter/commit/?id=a22859a64a6

Testing now.

Comment 3 Adam Jackson 2012-05-03 18:58:22 UTC
That, plus this:

http://git.gnome.org/browse/mutter/commit/?id=ed358c8f4b1200

makes 'gnome-shell --cogl-debug=disable-npot-textures --replace' work again (tested on Intel GM45 GPU).

Comment 4 Adam Williamson 2012-05-09 15:09:02 UTC
Proposing as a blocker, as this is another case of Shell not working right on quite a lot of hardware. Possible actions here are either to fix the bug (but the patches may not be entirely safe at this late stage) or to blacklist all NVIDIAs up to nv3x. We could of course then ship a post-release mutter update to fix the bug, and a gnome-session update which depended on that version of mutter and withdrew the blacklisting.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 5 Adam Williamson 2012-05-09 18:44:57 UTC
Opinions on which of the two options is preferable are desired. ;)



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 6 Ben Skeggs 2012-05-10 01:02:21 UTC
If you're going to go with a blacklisting option, I'd blacklist on any GL not reporting support for GL_ARB_texture_non_power_of_two.  This would automagically blacklist any card that'll hit the issue (<=NV3x in nouveau's case).

I really prefer the actual problem being fixed though :)

Comment 7 Fedora Update System 2012-05-10 15:40:02 UTC
mutter-3.4.1-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/mutter-3.4.1-3.fc17

Comment 8 Stephen Sheldon 2012-05-10 16:56:16 UTC
I tried the mutter build in Comment 7 with my NV34 FX5200 card, and window contents are now displayed correctly.  I still have the text problems I reported in BZ 745202, originally against FC16.

Comment 9 Fedora Update System 2012-05-10 20:38:53 UTC
Package mutter-3.4.1-3.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing mutter-3.4.1-3.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-7614/mutter-3.4.1-3.fc17
then log in and leave karma (feedback).

Comment 10 Adam Williamson 2012-05-10 22:00:29 UTC
stephen: I think we'll keep NV34 blacklisted for the text issues.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 11 Adam Williamson 2012-05-11 03:04:01 UTC
I'm +1 blocker on this one. I think it's worth taking the good fix for it rather than blacklisting.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 12 Adam Williamson 2012-05-12 00:48:12 UTC
Discussed at the 2012-05-11 blocker review meeting: http://meetbot.fedoraproject.org/fedora-bugzappers/2012-05-11/f17-final-blocker-review-meeting-5.2012-05-11-17.04.html . This was accepted as NTH. There was not a clear consensus on whether it should be a blocker bug, so that status is left open for further review (though the NTH acceptance means the fix will be pulled anyway).



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 13 Tim Flink 2012-05-14 18:44:51 UTC
Discussed at the 2012-05-14 mini blocker review meeting. Accepted as a blocker for Fedora 17 final due to violation of the following Fedora 17 alpha release criterion [1] for specific graphics cards:

"Following on from the previous criterion, after firstboot is completed and on subsequent boots, a system installed according to any of the above criteria (or the appropriate Beta or Final criteria, when applying this criterion to those releases) must boot to a working graphical environment without unintended user intervention. This includes correctly accessing any encrypted partitions when the correct passphrase is supplied"

Comment 14 Adam Williamson 2012-05-15 02:22:31 UTC
Having this as NTH *and* blocker is overkill...



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 15 Fedora Update System 2012-05-15 05:25:43 UTC
mutter-3.4.1-3.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 16 Adam Jackson 2012-05-16 16:34:59 UTC
*** Bug 797025 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.