RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 813953 - block-job-set-speed is racy with block-stream/drive-mirror
Summary: block-job-set-speed is racy with block-stream/drive-mirror
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: qemu-kvm
Version: 6.3
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: 6.3
Assignee: Jeff Cody
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On: 582475 783950 812085
Blocks: 525307 580954 638506 638508 638509 748534 756082 769496 786141 799055 802284 806280 806432 811683 815791 830861 831532 835344 835345 835722 865384
TreeView+ depends on / blocked
 
Reported: 2012-04-18 20:39 UTC by Eric Blake
Modified: 2013-01-10 00:53 UTC (History)
30 users (show)

Fixed In Version: qemu-kvm-0.12.1.2-2.290.el6
Doc Type: Bug Fix
Doc Text:
No Documentation Needed
Clone Of: 812085
Environment:
Last Closed: 2012-06-20 11:47:01 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0746 0 normal SHIPPED_LIVE qemu-kvm bug fix and enhancement update 2012-06-19 19:31:48 UTC

Comment 1 Shaolong Hu 2012-04-19 02:50:52 UTC
how about implement block_stream and block-job-set-speed in transaction? Then a block_stream + block-job-set-speed or __com.redhat.drive-mirror + block-job-set-speed transaction should work.

Comment 2 juzhang 2012-04-19 03:25:11 UTC
According to bug description, qe can reproduce with qemu-kvm-rhev-278,mark qa_ack+
(qemu) block-job-set-speed ide1-cd0 1M
Device 'ide1-cd0' has not been activated by the guest

Comment 6 Eric Blake 2012-04-24 14:28:50 UTC
v2 of upstream patch proposal:
https://lists.gnu.org/archive/html/qemu-devel/2012-04/msg03510.html

- change block-job-set-speed to use parameter name 'speed' instead of 'value'
- add optional 'speed' parameter to 'block-stream'
- add optional 'speed' parameter to '__com.redhat_drive-mirror'

Comment 7 Eric Blake 2012-04-24 14:31:06 UTC
Updating the title; the upstream qemu solution appears to be headed towards setting the speed as part of starting a job, at which point it would still be an expected error to attempt to set the speed while a job is not running; the difference in verification would be checking that the optional parameter is present when starting the job and setting speed in one monitor call rather than the current constraint of two separate calls.

Comment 9 Jeff Cody 2012-05-01 15:58:04 UTC
Posted to rhvirt

Comment 12 Michal Novotny 2012-05-04 13:31:48 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
No Documentation Needed

Comment 13 Shaolong Hu 2012-05-17 06:58:05 UTC
Verified on qemu-kvm-rhev-0.12.1.2-2.292.el6.x86_64:

1. mirroring with speed set to 10M at beginning, after steady state, reopen to target, reboot guest, guest works correctly:

{ "execute" : "__com.redhat_drive-mirror", "arguments" : { "device" : "drive-virtio-disk0", "target" : "/dev/disk/by-path/ip-10.66.9.64:3260-iscsi-iqn.2001-04.com.example:storage.disk1.amiens.sys1.xyz-lun-2", "format": "qcow2", "mode": "absolute-paths", "speed": 10485760, "full" : false } }
{"return": {}}

{ "execute": "__com.redhat_drive-reopen", "arguments": {"device": "drive-virtio-disk0", "new-image-file": "/dev/disk/by-path/ip-10.66.9.64:3260-iscsi-iqn.2001-04.com.example:storage.disk1.amiens.sys1.xyz-lun-2", "format": "qcow2" } }
{"timestamp": {"seconds": 1337189124, "microseconds": 258318}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "drive-virtio-disk0", "len": 21474836480, "offset": 21474836480, "speed": 109951162777600, "type": "mirror"}}
{"return": {}}

2. streaming with speed set to 10M

{ "execute": "blockdev-snapshot-sync", "arguments": { "device": "drive-virtio-disk0", "snapshot-file": "/dev/disk/by-path/ip-10.66.9.64:3260-iscsi-iqn.2001-04.com.example:storage.disk1.amiens.sys1.xyz-lun-2", "mode": "absolute-paths", "format": "qcow2" } }
{"return": {}}

{ "execute": "block-stream", "arguments": { "device": "drive-virtio-disk0", "speed": 10485760 } }
{"return": {}}

{"timestamp": {"seconds": 1337265302, "microseconds": 451952}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "drive-virtio-disk0", "len": 21474836480, "offset": 21474836480, "speed": 1099511627776000, "type": "stream"}}


Based on above results, fixed.

Comment 14 Chao Yang 2012-05-18 04:38:28 UTC
Moving to VERIFIED as per Comment #2 and Comment #13

Comment 15 Shaolong Hu 2012-05-23 10:06:10 UTC
Doc has not been modified, open new one to track:
Bug 824338 - invalid argument in block-job-set-speed document

Comment 16 errata-xmlrpc 2012-06-20 11:47:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0746.html


Note You need to log in before you can comment on or make changes to this bug.