RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 814080 - Syscall param rt_sigaction(act->sa_flags) points to uninitialised byte(s)
Summary: Syscall param rt_sigaction(act->sa_flags) points to uninitialised byte(s)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt
Version: 6.3
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Alex Jia
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 811683
TreeView+ depends on / blocked
 
Reported: 2012-04-19 08:03 UTC by Alex Jia
Modified: 2012-06-20 06:54 UTC (History)
7 users (show)

Fixed In Version: libvirt-0.9.10-14.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-20 06:54:39 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2012:0748 0 normal SHIPPED_LIVE Low: libvirt security, bug fix, and enhancement update 2012-06-19 19:31:38 UTC

Description Alex Jia 2012-04-19 08:03:17 UTC 
Description of problem:
The function cmdBlockPull() uses uninitialised memory.

Version-Release number of selected component (if applicable):
# rpm -q libvirt-client
libvirt-client-0.9.10-13.el6.x86_64


How reproducible:
always.

Steps to Reproduce:
$ qemu-img create /var/lib/libvirt/images/test 1M

$ cat > /tmp/test.xml <<EOF
<domain type='qemu'>
  <name>test</name>
  <memory>219200</memory>
  <vcpu>1</vcpu>
  <os>
    <type arch='x86_64'>hvm</type>
    <boot dev='hd'/>
  </os>
  <devices>
    <disk type='file' device='disk'>
      <driver name='qemu' type='raw'/>
      <source file='/var/lib/libvirt/images/test'/>
      <target dev='vda' bus='virtio'/>
    </disk>
    <input type='mouse' bus='ps2'/>
    <graphics type='spice' autoport='yes' listen='0.0.0.0'/>
  </devices>
</domain>
EOF

$ virsh define /tmp/test.xml
$ valgrind -v virsh blockpull test /var/lib/libvirt/images/test --wait

  
Actual results:

==10906== 1 errors in context 1 of 1:
==10906== Syscall param rt_sigaction(act->sa_flags) points to uninitialised byte(s)
==10906==    at 0x39CF80F5BE: __libc_sigaction (sigaction.c:67)
==10906==    by 0x43016C: cmdBlockPull (virsh.c:7638)
==10906==    by 0x4150D4: vshCommandRun (virsh.c:18574)
==10906==    by 0x425E73: main (virsh.c:20178)
==10906==  Address 0x7fefffae8 is on thread 1's stack

Expected results:
fix uninitialized memory usage.

Additional info:
Comment 1 Alex Jia 2012-04-19 08:04:21 UTC 
Patch for upstream:
https://www.redhat.com/archives/libvir-list/2012-April/msg00980.html
Comment 2 Alex Jia 2012-04-20 05:41:19 UTC 
In POST:
commit 2aed9a97f86ed2fd868ca3240c07076e116ced7b
Author: Eric Blake <eblake>
Date:   Thu Apr 19 16:51:11 2012 +0800

    virsh: avoid uninitialized memory usage
    
    Detected by valgrind, via Alex Jia.  Caused by imcomplete
    copy-and-paste from vshWatchJob in commit 3b96a892.
    
    * tools/virsh.c (cmdBlockPull): fix uninitialized memory usage.
Comment 4 Eric Blake 2012-04-24 04:14:30 UTC 
I marked this separately in bug 782457#c23, since that one had not been verified yet.

*** This bug has been marked as a duplicate of bug 782457 ***
Comment 5 Eric Blake 2012-04-24 04:20:20 UTC 
Wrong bug comment; I meant: dup of bug 811683#c11

*** This bug has been marked as a duplicate of bug 811683 ***
Comment 6 Eric Blake 2012-04-24 04:22:59 UTC 
In POST:
http://post-office.corp.redhat.com/archives/rhvirt-patches/2012-April/msg00704.html
Comment 9 Alex Jia 2012-04-24 08:31:54 UTC 
The issue has been fixed on rhel6.2 with libvirt-0.9.10-14.el6.x86_64.

BTW, I will meet the following error. it should be a expected result, right?
error: unsupported configuration: block jobs not supported with this QEMU binary
Comment 18 Alex Jia 2012-04-26 15:54:26 UTC 
Move the bug to verified status based on Comment 9.
Comment 20 errata-xmlrpc 2012-06-20 06:54:39 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0748.html
Note You need to log in before you can comment on or make changes to this bug.