Red Hat Bugzilla – Bug 814080
Syscall param rt_sigaction(act->sa_flags) points to uninitialised byte(s)
Last modified: 2012-06-20 02:54:39 EDT
Description of problem: The function cmdBlockPull() uses uninitialised memory. Version-Release number of selected component (if applicable): # rpm -q libvirt-client libvirt-client-0.9.10-13.el6.x86_64 How reproducible: always. Steps to Reproduce: $ qemu-img create /var/lib/libvirt/images/test 1M $ cat > /tmp/test.xml <<EOF <domain type='qemu'> <name>test</name> <memory>219200</memory> <vcpu>1</vcpu> <os> <type arch='x86_64'>hvm</type> <boot dev='hd'/> </os> <devices> <disk type='file' device='disk'> <driver name='qemu' type='raw'/> <source file='/var/lib/libvirt/images/test'/> <target dev='vda' bus='virtio'/> </disk> <input type='mouse' bus='ps2'/> <graphics type='spice' autoport='yes' listen='0.0.0.0'/> </devices> </domain> EOF $ virsh define /tmp/test.xml $ valgrind -v virsh blockpull test /var/lib/libvirt/images/test --wait Actual results: ==10906== 1 errors in context 1 of 1: ==10906== Syscall param rt_sigaction(act->sa_flags) points to uninitialised byte(s) ==10906== at 0x39CF80F5BE: __libc_sigaction (sigaction.c:67) ==10906== by 0x43016C: cmdBlockPull (virsh.c:7638) ==10906== by 0x4150D4: vshCommandRun (virsh.c:18574) ==10906== by 0x425E73: main (virsh.c:20178) ==10906== Address 0x7fefffae8 is on thread 1's stack Expected results: fix uninitialized memory usage. Additional info:
Patch for upstream: https://www.redhat.com/archives/libvir-list/2012-April/msg00980.html
In POST: commit 2aed9a97f86ed2fd868ca3240c07076e116ced7b Author: Eric Blake <eblake@redhat.com> Date: Thu Apr 19 16:51:11 2012 +0800 virsh: avoid uninitialized memory usage Detected by valgrind, via Alex Jia. Caused by imcomplete copy-and-paste from vshWatchJob in commit 3b96a892. * tools/virsh.c (cmdBlockPull): fix uninitialized memory usage.
I marked this separately in bug 782457#c23, since that one had not been verified yet. *** This bug has been marked as a duplicate of bug 782457 ***
Wrong bug comment; I meant: dup of bug 811683#c11 *** This bug has been marked as a duplicate of bug 811683 ***
In POST: http://post-office.corp.redhat.com/archives/rhvirt-patches/2012-April/msg00704.html
The issue has been fixed on rhel6.2 with libvirt-0.9.10-14.el6.x86_64. BTW, I will meet the following error. it should be a expected result, right? error: unsupported configuration: block jobs not supported with this QEMU binary
Move the bug to verified status based on Comment 9.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2012-0748.html