Bug 815305 - Min/max constraints on PropertyList not honored
Min/max constraints on PropertyList not honored
Product: RHQ Project
Classification: Other
Component: Core UI (Show other bugs)
Unspecified Unspecified
medium Severity unspecified (vote)
: ---
: RHQ 4.5.0
Assigned To: Mike Thompson
Mike Foley
Depends On:
Blocks: 820425
  Show dependency treegraph
Reported: 2012-04-23 06:25 EDT by Heiko W. Rupp
Modified: 2013-09-01 06:16 EDT (History)
3 users (show)

See Also:
Fixed In Version: 4.5.0
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2013-09-01 06:16:46 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Max bounds alert (49.99 KB, image/png)
2012-07-12 15:33 EDT, Mike Thompson
no flags Details
Min bounds alert (56.15 KB, image/png)
2012-07-12 15:34 EDT, Mike Thompson
no flags Details

  None (edit)
Description Heiko W. Rupp 2012-04-23 06:25:20 EDT

<c:list-property> it is possible  to specify the min/max number of occurrences of items of the contained
type .
Unfortunately this is not honored at all in core gui.

Digging into it, shows that the PropertyDefinitionList has the min/max attribute marked as
@Transient -> so they are not even stored in the database.

This would be needed to to say that an XA-Datasource in as7 needs at least one XA-property
Comment 2 Mike Foley 2012-04-23 12:11:02 EDT
setting priority to medium per BZ triage 4/23 (crouch, santos, oleary, foley)
Comment 3 Heiko W. Rupp 2012-04-24 11:24:42 EDT
See also https://bugzilla.redhat.com/show_bug.cgi?id=802467#c4
Comment 4 Mike Thompson 2012-07-12 15:33:38 EDT
Created attachment 597887 [details]
Max bounds alert
Comment 5 Mike Thompson 2012-07-12 15:34:04 EDT
Created attachment 597888 [details]
Min bounds alert
Comment 6 Mike Thompson 2012-07-12 17:28:01 EDT
Master commit id: 46f6c86

UI now detects the min and max attributes on the PropertyDefinitionList and validates the number of elements based on the plugin xml config values. See attached screen shots for what the alerting looks like.
Comment 7 John Mazzitelli 2012-07-13 14:34:49 EDT
this is the description from 5 years ago - JBNADM-1595, created by Heiko:

Heiko is always ahead of his time :-)

Testcase in PluginHandlingTest.testListPropertyMinMax()

<list-property name="a"
description="Yada !"
max="6" />

name and description are correctly set, but not min and max

Looking at PropertyDefinitionList shows that the properties min/max are transient. IMHO this makes the properties useless.
Comment 8 Heiko W. Rupp 2013-09-01 06:16:46 EDT
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.

Note You need to log in before you can comment on or make changes to this bug.