Bug 815428 - Review Request: perl-Module-Manifest-Skip - MANIFEST.SKIP Manangement for Modules
Review Request: perl-Module-Manifest-Skip - MANIFEST.SKIP Manangement for Mod...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Šabata
Fedora Extras Quality Assurance
Depends On:
Blocks: 815437
  Show dependency treegraph
Reported: 2012-04-23 11:20 EDT by Petr Pisar
Modified: 2012-05-10 02:19 EDT (History)
3 users (show)

See Also:
Fixed In Version: perl-Module-Manifest-Skip-0.16-1.fc18
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-05-10 02:19:04 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
psabata: fedora‑review+
limburgher: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Petr Pisar 2012-04-23 11:20:52 EDT
Spec URL: http://ppisar.fedorapeople.org/perl-Module-Manifest-Skip/perl-Module-Manifest-Skip.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Module-Manifest-Skip/perl-Module-Manifest-Skip-0.16-1.fc18.src.rpm
CPAN module authors use a MANIFEST.SKIP file to exclude certain well known
files from getting put into a generated MANIFEST file, which would cause them
to go into the final distribution package.

The packaging tools try to automatically skip things for you, but if you add
one of your own entries, you have to add all the common ones yourself.  This
module attempts to make all of this boring process as simple and reliable as
Comment 1 Petr Šabata 2012-05-09 11:40:53 EDT
Package Review

- = N/A
x = Pass
! = Fail
? = Not evaluated

==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[!]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/contyk/src/review/815428/Module-Manifest-Skip-0.16.tar.gz :
  MD5SUM this package     : 465ac6f9ad01d9042d1b87b6c2440f6f
  MD5SUM upstream package : 465ac6f9ad01d9042d1b87b6c2440f6f

[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[-]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: SHOULD Package should compile and build into binary rpms on all supported
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
[-]: SHOULD Spec use %global instead of %define.

TODO: Ask upstream to update their LICENSE with the current FSF address.
TODO: Add perl(Cwd) to your build dependencies (tests only).

Generated by fedora-review 0.2.0git
External plugins:
Comment 2 Petr Pisar 2012-05-09 11:48:09 EDT
New Package SCM Request
Package Name: perl-Module-Manifest-Skip 
Short Description: MANIFEST.SKIP Manangement for Modules
Owners: ppisar mmaslano psabata
InitialCC: perl-sig
Comment 3 Gwyn Ciesla 2012-05-09 12:56:42 EDT
Git done (by process-git-requests).
Comment 4 Petr Pisar 2012-05-10 02:19:04 EDT
Thank you for the review and the repository.

The old address has been already reported (https://rt.cpan.org/Public/Bug/Display.html?id=76774).

I added the missing perl(Cwd).

Note You need to log in before you can comment on or make changes to this bug.