Bug 815516 - pam remember can check wrong username if it is a substring of another username
pam remember can check wrong username if it is a substring of another username
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: pam (Show other bugs)
6.3
i386 Linux
unspecified Severity medium
: rc
: 6.4
Assigned To: Tomas Mraz
Dalibor Pospíšil
:
Depends On:
Blocks: 836160
  Show dependency treegraph
 
Reported: 2012-04-23 14:40 EDT by Tomas Mraz
Modified: 2013-02-21 05:36 EST (History)
3 users (show)

See Also:
Fixed In Version: pam-1.1.1-12.el6
Doc Type: Bug Fix
Doc Text:
Cause: The pam_unix remember option functionality incorrectly matched user names in the /etc/security/opasswd file. Consequence: Users with their user name being a prefix of another user name could sometimes get incorrectly restricted with passwords of the other user when changing their password or overwrite old passwords of the other user account. Fix: The pam_unix module was fixed to properly match the whole user name when looking up records in /etc/security/opasswd file. Result: Users are now correctly restricted with their own old passwords and old password records of another user are no longer overwritten.
Story Points: ---
Clone Of: 768087
Environment:
Last Closed: 2013-02-21 05:36:56 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Tomas Mraz 2012-04-23 14:40:07 EDT
+++ This bug was initially created as a clone of Bug #768087 +++

Description of problem:
The remember functionality of pam_unix can compare against the wrong username’s old passwords if the username is a substring of another username.  The substring must be at the beginning of both usernames for this to occur.  For example, a username ‘test’ will look at the old passwords of ‘test123’.

Version-Release number of selected component (if applicable):
pam-0.99.6.2-6.el5_5.2.i386.rpm

How reproducible:
Always

Steps to Reproduce:
1.  Make sure remember=8 or something similar is enabled on pam_unix in the password stack
2.  Create a user ‘test1’ and change the password a few times
3.  Create a user ‘test’ and change the password to a previous password of test1

  
Actual results:
The password change is denied, however, it should not have been.

Expected results:
The password change is allowed.

Additional info:

You can see the erroneous code in pam_unix_passwd.c inside of the pam_unix module directory (in function save_old_password):

    while (fgets(buf, 16380, opwfile)) {
    if (!strncmp(buf, forwho, strlen(forwho))) {

The fix is to search for a line that starts with the username followed immediately by a colon.  


The same erroneous code exists in "pam_unix_passwd.c" in function check_old_password:

    while (fgets(buf, 16380, opwfile)) {
        if (!strncmp(buf, forwho, strlen(forwho))) {
Comment 4 errata-xmlrpc 2013-02-21 05:36:56 EST
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0521.html

Note You need to log in before you can comment on or make changes to this bug.