Bug 815575 – PATCH: properly deal with crypt() returning NULL

Bug 815575 - PATCH: properly deal with crypt() returning NULL

Summary:	PATCH: properly deal with crypt() returning NULL

Status:	CLOSED RAWHIDE

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	apg (Show other bugs)
Sub Component:
Version:	17
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	---
Target Release:	---
Assigned To:	Kevin Fenzi
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2012-04-23 18:15 EDT by Paul Wouters
Modified:	2012-04-23 21:16 EDT (History)
CC List:	1 user (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2012-04-23 21:16:47 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
patch hanlding crypt() returning NULL (1.82 KB, patch) 2012-04-23 18:16 EDT, Paul Wouters	no flags	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Paul Wouters 2012-04-23 18:15:57 EDT

the crypt() call can return NULL in some error conditions. One of those is when the computer is running in FIPS mode and an MD5 or DES hash is requested.

Attached patch fixes the direct/indirect calls to crypt() where it is not checked for NULL before being used in operations as strchr() or strcmp()

Comment 1 Paul Wouters 2012-04-23 18:16:39 EDT

Created attachment 579707 [details]
patch hanlding crypt() returning NULL

Comment 2 Kevin Fenzi 2012-04-23 21:16:47 EDT

Build in rawhide. thanks!

let me know if you think this deserves stable updates...

Note You need to log in before you can comment on or make changes to this bug.