Bug 815575 - PATCH: properly deal with crypt() returning NULL
Summary: PATCH: properly deal with crypt() returning NULL
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: apg
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-04-23 22:15 UTC by Paul Wouters
Modified: 2012-04-24 01:16 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-04-24 01:16:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
patch hanlding crypt() returning NULL (1.82 KB, patch)
2012-04-23 22:16 UTC, Paul Wouters
no flags Details | Diff

Description Paul Wouters 2012-04-23 22:15:57 UTC
the crypt() call can return NULL in some error conditions. One of those is when the computer is running in FIPS mode and an MD5 or DES hash is requested.

Attached patch fixes the direct/indirect calls to crypt() where it is not checked for NULL before being used in operations as strchr() or strcmp()

Comment 1 Paul Wouters 2012-04-23 22:16:39 UTC
Created attachment 579707 [details]
patch hanlding crypt() returning NULL

Comment 2 Kevin Fenzi 2012-04-24 01:16:47 UTC
Build in rawhide. thanks!

let me know if you think this deserves stable updates...


Note You need to log in before you can comment on or make changes to this bug.