Bug 815605 - PATCH: screen does not properly handle crypt() returning NULL
Summary: PATCH: screen does not properly handle crypt() returning NULL
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: screen
Version: 17
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Lukáš Nykrýn
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-04-24 03:50 UTC by Paul Wouters
Modified: 2012-04-26 10:45 UTC (History)
1 user (show)

Fixed In Version: screen-4.1.0-0.10.20120314git3c2946.fc18
Clone Of:
Environment:
Last Closed: 2012-04-26 10:44:56 UTC
Type: Bug
Embargoed:

Attachments (Terms of Use)
patch hanlding crypt() returning NULL (3.45 KB, patch)
2012-04-24 03:51 UTC, Paul Wouters 		no flags Details | Diff
View All

Description Paul Wouters 2012-04-24 03:50:37 UTC 
crypt() can return NULL, but screen uses functions like strcmp() directly on the return value of crypt().

crypt() can return NULL when the system is in fips mode and the hashing algorithm passed via the salt value is not allowed (eg md5)

Attached is a patch
Comment 1 Paul Wouters 2012-04-24 03:51:18 UTC 
Created attachment 579740 [details]
patch hanlding crypt() returning NULL
Comment 2 Lukáš Nykrýn 2012-04-26 08:50:27 UTC 
Thanks for the patch, I have also sent it to upstream.
Comment 3 Lukáš Nykrýn 2012-04-26 10:44:56 UTC 
patch committed to git-> http://lists.fedoraproject.org/pipermail/scm-commits/
Note You need to log in before you can comment on or make changes to this bug.