Bug 816559 - Review Request: perl-Test-Module-Used - Test required module is really used and vice versa between lib/t and META.yml
Review Request: perl-Test-Module-Used - Test required module is really used a...
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Petr Šabata
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-26 08:01 EDT by Petr Pisar
Modified: 2012-05-23 10:57 EDT (History)
3 users (show)

See Also:
Fixed In Version: perl-Test-Module-Used-0.2.3-1.fc18
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-05-23 10:57:25 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
psabata: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Petr Pisar 2012-04-26 08:01:12 EDT
Spec URL: http://ppisar.fedorapeople.org/perl-Test-Module-Used/perl-Test-Module-Used.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Test-Module-Used/perl-Test-Module-Used-0.2.3-1.fc18.src.rpm
Description:
This module reads META.yml and get build_requires and requires. It compares
required module is really used and used module is really required.
Comment 1 Petr Šabata 2012-05-23 08:43:00 EDT
Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated


==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[!]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[-]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean is needed only if supporting EPEL
[x]: MUST Sources contain only permissible code or content.
[!]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: defattr(....) present in %files section. This is OK if packaging
     for EPEL5. Otherwise not needed
[-]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package requires other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf is only needed if supporting EPEL5
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[-]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[x]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[x]: MUST Rpmlint output is silent.
[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
/home/contyk/src/review/816559/Test-Module-Used-0.2.3.tar.gz :
  MD5SUM this package     : ccf2370e06097a8d6e4f0590ebe1f915
  MD5SUM upstream package : ccf2370e06097a8d6e4f0590ebe1f915
[!]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[-]: MUST Useful -debuginfo package or justification otherwise.
[!]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[-]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[x]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[-]: SHOULD Spec use %global instead of %define.

Issues:
FIX: The package doesn't build; this could be fixed by removed the author_requires lines from Makefile.PL.
TODO: Drop the obsolete %clean, buildroot removal, and %defattr.
TODO: Change 'get' to 'gets' in the package %description.

Generated by fedora-review 0.2.0git
External plugins:
Comment 2 Petr Pisar 2012-05-23 09:28:58 EDT
Updated package is on the same address.

The build failed because of missing another author Module::Install module. It turns out that the other module pulls modules defined by author_requires statements in Makefile.PL. And because I do not want to run the author tests, I removed the statements from Makefile.PL and MANIFEST to keep build-require set smaller.
Comment 3 Petr Šabata 2012-05-23 10:07:44 EDT
Approving.
Comment 4 Petr Pisar 2012-05-23 10:31:45 EDT
New Package SCM Request
=======================
Package Name: perl-Test-Module-Used
Short Description: Test required module is really used and vice versa between lib/t and META.yml
Owners: ppisar jplesnik mmaslano psabata
Branches: 
InitialCC: perl-sig
Comment 5 Gwyn Ciesla 2012-05-23 10:39:36 EDT
Git done (by process-git-requests).
Comment 6 Petr Pisar 2012-05-23 10:57:25 EDT
Thank you for the review and the repository.

Note You need to log in before you can comment on or make changes to this bug.