Bug 816807 - Off-by-one error in FullFastIterator.next() leads to botched queries
Summary: Off-by-one error in FullFastIterator.next() leads to botched queries
Keywords:
Status: VERIFIED
Alias: None
Product: JBoss Enterprise BRMS Platform 5
Classification: JBoss
Component: BRE (Expert, Fusion)
Version: BRMS 5.3.0.GA
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ER7
: BRMS 5.3.0.GA
Assignee: Nobody
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-04-27 04:39 UTC by Mark Proctor
Modified: 2023-05-01 08:28 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker JBRULES-3483 0 None Closed Off-by-one error in FullFastIterator.next() leads to botched queries 2012-05-28 01:29:55 UTC

Description Mark Proctor 2012-04-27 04:39:17 UTC 
The rete node memory iterators will skip entries in the last bucket after it has found the first entry, due to a check against the current row.

This is a critical fix as it results in loss of integirty and corruption of running applications.
Comment 1 Mark Proctor 2012-04-27 04:59:07 UTC 
commit for master:
https://github.com/droolsjbpm/drools/commit/483f6b6f19209b786d2e1f32ecfb6da3c42676bc

commit for 5.4.x:
https://github.com/droolsjbpm/drools/commit/4fc60f02a72b4b3b56767335bcb3e7b78d5ad940
Comment 2 JBoss JIRA Server 2012-04-27 05:02:57 UTC 
Mark Proctor <mproctor> updated the status of jira JBRULES-3483 to Resolved
Comment 3 JBoss JIRA Server 2012-04-27 05:03:08 UTC 
Mark Proctor <mproctor> updated the status of jira JBRULES-3483 to Closed
Comment 4 JBoss JIRA Server 2012-04-27 05:05:48 UTC 
Adar Dembo <adar> made a comment on jira JBRULES-3483

What about a backport for 5.3.x? That's the latest stable release, right?
Comment 5 Mark Proctor 2012-05-04 16:45:48 UTC 
yes I've said this must be backported to 5.3. I'm awaiting permission to do so.
Comment 6 Edson Tirelli 2012-05-04 16:59:35 UTC 
Cherry-picked into 5.3.x branch as requested by Mark.

https://github.com/droolsjbpm/drools/commit/20f2682afb65381ad2a32ec8431448e2bd974fd8
Comment 7 Ryan Zhang 2012-05-14 08:16:14 UTC 
The fixed for this issue should be included in ER7. Please do verification on it.
Comment 9 Lukáš Petrovický 2012-05-22 08:39:14 UTC 
The fix is in ER7 and the test doesn't fail. VERIFIED.
Note You need to log in before you can comment on or make changes to this bug.