Bug 817602 - Review Request: luola-nostalgia - Nostalgia level pack for luola
Summary: Review Request: luola-nostalgia - Nostalgia level pack for luola
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: http://www.luolamies.org/software/luola
Whiteboard:
Depends On: 817597
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2012-04-30 15:33 UTC by inactive
Modified: 2015-08-21 09:43 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-08-21 09:43:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
updated spec file (1004 bytes, application/octet-stream)
2012-05-02 18:08 UTC, Dan Mashal
no flags Details
rpmbuild output (3.29 KB, text/plain)
2012-05-02 18:11 UTC, Dan Mashal
no flags Details

Description inactive 2012-04-30 15:33:49 UTC
Spec URL: http://jor.netne.net/files/luola-nostalgia.spec
SRPM URL: http://jor.netne.net/files/luola-nostalgia-1.2-1.fc16.src.rpm
Description: Luola is a 2D arcade game where you fly a small V shaped ship in different kinds of levels. This packages contains the four "nostalgia" levels Twilight Zone, Citadel of Yoqu, Twin Cities and Duh Caves

Comment 1 Dan Mashal 2012-05-02 18:08:51 UTC
Created attachment 581683 [details]
updated spec file

Comment 2 Dan Mashal 2012-05-02 18:10:20 UTC
I updated your spec file. Please check it.

[vicodan@Fedora17 SPECS]$ rpmlint luola-nostalgia.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Also I have attached my output of rpmbuild.

Comment 3 Dan Mashal 2012-05-02 18:11:06 UTC
Created attachment 581684 [details]
rpmbuild output

Comment 4 Dan Mashal 2012-05-02 18:12:44 UTC
Again, I ask why you can't compile these all in to one package?

Comment 5 Rex Dieter 2012-05-02 18:42:48 UTC
Fwiw, compiling multiple upstream projects/tarballs into a single package is generally discouraged.  upstreams generally release items separately *on purpose*, so to do otherwise you need some really good reasons to do so.

Comment 6 inactive 2012-05-02 21:10:08 UTC
Dan, you removed the:
PreReq:		luola
Provides:	luola-level
in your updated spec, why?

the level package requires the game, already because it owns the /usr/share/luola/levels/ directory and the virtual package luola-level is there to make sure a levelset is installed with the game (without levels in /usr/share/luola/levels/, the game won't start)

Comment 7 Miroslav Suchý 2015-08-21 09:43:21 UTC
No response in bug 817597. Closing. Feel free to reopen if you want to continue.


Note You need to log in before you can comment on or make changes to this bug.