RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 818449 - mirroring in QMP transaction with "full"=false is treated as "full"=true
Summary: mirroring in QMP transaction with "full"=false is treated as "full"=true
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: qemu-kvm
Version: 6.3
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: rc
: ---
Assignee: Paolo Bonzini
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks: 806280
TreeView+ depends on / blocked
 
Reported: 2012-05-03 06:33 UTC by Shaolong Hu
Modified: 2012-07-12 08:39 UTC (History)
10 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-07-12 08:39:50 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)

Description Shaolong Hu 2012-05-03 06:33:33 UTC 
Description of problem:
------------------------
mirroring in QMP transaction with "full"=false is treated as "full"=true


Version-Release number of selected component (if applicable):
--------------------------------------------------------------
qemu-kvm-rhev-0.12.1.2-2.282.el6.x86_64
qemu-kvm-rhev-0.12.1.2-2.288.el6.x86_64


How reproducible:
-----------------
100%


Steps to Reproduce:
--------------------
1.start guest with base:

{ "execute": "transaction",
     "arguments": { "actions": [
         { 'type': 'blockdev-snapshot-sync', 'data' : { "device":
"drive-virtio-disk0",
                                         "snapshot-file": "/root/sn1",
                                         "format": "qcow2" } },
         { 'type': '__com.redhat_drive-mirror', 'data' : { "device":
"drive-virtio-disk0",
                                         "target": "/root/sn2",
                                         "mode": "absolute-paths",
                                         "format": "qcow2",
                                         "full": false } } ] } }

2. in step 1, i specify "full"=false, but after step 1, base is copied to sn2

3. 
[root@shu ~]# qemu-img info sn1
image: sn1
file format: qcow2
virtual size: 30G (32212254720 bytes)
disk size: 31M
cluster_size: 65536
backing file: win7-64-virtio.qcow2 (actual path: win7-64-virtio.qcow2)

[root@shu ~]# qemu-img info sn2
image: sn2
file format: qcow2
virtual size: 30G (32212254720 bytes)
disk size: 7.6G
cluster_size: 65536

[root@shu ~]# qemu-img info win7-64-virtio.qcow2 
image: win7-64-virtio.qcow2
file format: qcow2
virtual size: 30G (32212254720 bytes)
disk size: 7.4G
cluster_size: 65536

here win7-64-virtio.qcow2 is the base.


Expected results:
------------------
only sn1 is copied to sn2.
Comment 2 Paolo Bonzini 2012-05-03 09:37:54 UTC 
The issue here is that drive-mirror uses the disk at the *beginning* of the transaction as the source, rather than the disk at the current point of the transaction.

It can be fixed, but libvirt is not using the transaction functionality and it will not be included in the upstream code. For this reason a WONTFIX would be nice if libvirt and vdsm guys agree. Federico/Eric, any opinion?
Comment 3 Eric Blake 2012-05-03 13:07:15 UTC 
I'm agreed that a WONTFIX for 6.3 is appropriate; streaming mirror without transaction solves the original design problem of storage migration as needed by vdsm, and libvirt doesn't expose snapshot+mirror transactions (I wrote the patches for that, but they were not applied), so the only other way to exercise this code path would be by unsupported raw monitor commands.
Comment 4 Paolo Bonzini 2012-05-07 14:59:43 UTC 
Moved to 6.4, waiting for Federico's ack to WONTFIX it.
Comment 6 RHEL Program Management 2012-07-10 07:16:27 UTC 
This request was not resolved in time for the current release.
Red Hat invites you to ask your support representative to
propose this request, if still desired, for consideration in
the next release of Red Hat Enterprise Linux.
Comment 7 RHEL Program Management 2012-07-11 02:06:59 UTC 
This request was erroneously removed from consideration in Red Hat Enterprise Linux 6.4, which is currently under development.  This request will be evaluated for inclusion in Red Hat Enterprise Linux 6.4.
Comment 8 Paolo Bonzini 2012-07-12 08:39:50 UTC 
> libvirt is not using the transaction functionality and it will not be included 
> in the upstream code

Closing, the mirror transaction functionality is effectively dead code.
Note You need to log in before you can comment on or make changes to this bug.