Bug 818741 – Do not fall back to MD5 when crypt() falls its hashing algo

Bug 818741 - Do not fall back to MD5 when crypt() falls its hashing algo

Summary:	Do not fall back to MD5 when crypt() falls its hashing algo

Status:	CLOSED RAWHIDE

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	pam (Show other bugs)
Sub Component:
Version:	17
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	---
Target Release:	---
Assigned To:	Tomas Mraz
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2012-05-03 16:10 EDT by Paul Wouters
Modified:	2012-05-24 04:20 EDT (History)
CC List:	1 user (show)

See Also:
Fixed In Version:	pam-1.1.5-7.fc18
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2012-05-24 04:20:03 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
patch disabling MD5 fallback (3.05 KB, patch) 2012-05-03 16:11 EDT, Paul Wouters	no flags	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Paul Wouters 2012-05-03 16:10:05 EDT

Description of problem:
There is fallback code that uses crypt() in DES mode when it fails to work with another hashing algorithm via the $x$ salt argument passing.

In fips mode when MD5 is not allowed using a salt of $1$ (for MD5) results in crypt() returning NULL, and the fallback using the even worse then MD5 algo of single DES.

Comment 1 Paul Wouters 2012-05-03 16:11:51 EDT

Created attachment 581954 [details]
patch disabling MD5 fallback

Comment 2 Paul Wouters 2012-05-03 16:12:49 EDT

Slight correction, the fallback is to MD5 not DES, and it happens when the FIPS check fails for sha256/sha512.

Note You need to log in before you can comment on or make changes to this bug.