Red Hat Bugzilla – Bug 818991
Review Request: evolution-tray - Tray plugin for evolution
Last modified: 2015-12-03 23:28:06 EST
Spec URL: http://jor.netne.net/files/evolution-tray.spec
SRPM URL: http://jor.netne.net/files/evolution-tray-0.0.8-1.fc16.src.rpm
Description: This plugin puts evolution in "tray" (notification area).
While in tray evolution in minimized and it's windows skip the pager.
You can restore evolution on any workspace.
This package needs libgconf-bridge, which is only available from Debian based distros. See the Koji scratch build  for more info. How do you've got it working on your machine without this?
Furthermore, intltool and libnotify-devel are missing from BuildRequires.
It compiled on my x86_64 f16 without any third party packages/libraries. gconf/gconf-client.h (which was the missing header in the build you posted) is provided by GConf2-devel.
Libnotify-devel is not required.
I updated the spec and source rpm.
(In reply to comment #2)
> Thank you.
> It compiled on my x86_64 f16 without any third party packages/libraries.
> gconf/gconf-client.h (which was the missing header in the build you posted) is
> provided by GConf2-devel.
> Libnotify-devel is not required.
The plugin's website says:
>gtk+-2.0 (>= 2.14)
The following is from build.log (see Koji scratch build above):
>checking for LIBNOTIFY... no
>Package libnotify was not found in the pkg-config search path.
>Perhaps you should add the directory containing `libnotify.pc'
>to the PKG_CONFIG_PATH environment variable
>No package 'libnotify' found
Means, the configure script is looking for libnotify, and is unable to find it. Well, could be that this plugin works without that, but if both website and configure script say that it is needed, it should be true.
Once Evolution is bumped to a higher version number than 3.2, this declaration won't work anymore. Use instead:
Ok, fixed it both
As far as I can see, you are not a member of the package maintainers group. If you need a sponsor, please add FE-NEEDSPONSOR to the "Blocks:" field above.
I did that. What can I do next to get my Packages upstream?
(In reply to comment #6)
> I did that. What can I do next to get my Packages upstream?
That's all I could recommend for now. Unfortunately, I cannot sponsor you.
I am unable to access the spec file that you've put up. Are you working on getting sponsored and then continuing this review? If you're not up to it, I'd like to package this up and make it available in Fedora.
I can't build this. It requires "gconf/gconf-client.h" which doesn't seem to be available in Fedora. Will check gconf-bridge etc. and see. Some digging in required. Not quite sure how you built it Jonas.
i think it build fine with version 1.0, http://gnome.eu.org/cgit/evolution-tray/
but it doesn't seem to hide it when minimize nor does it maximize when it was click.
in fact, it doesn't even seem to do anything other than place an icon in the tray...
Ping! Are you still interrested in this review?
Closing this bug as a dead review as the requester appears to have deactivated their bugzilla.