Created attachment 582427[details]
log
Description of problem:
trying to create a template after I started a move disk operation gives an error:
Cannot add Template: VM's image is locked. Please try again in a few minutes.
since vm is no longer locked for actions that involve only disk operation we should change this error to "Disk X is locked" and not "Vm's image is locked"
Version-Release number of selected component (if applicable):
si3
How reproducible:
100%
Steps to Reproduce:
1. move a disk between two domains
2. try to create template
3.
Actual results:
only the disk is in locked state (sub tab under vm or disk tab) and vm is does not appear locked.
Expected results:
Error message should be changed
Additional info:log
2012-05-06 13:12:01,719 WARN [org.ovirt.engine.core.bll.AddVmTemplateCommand] (ajp--0.0.0.0-8009-7) [4dd3872c] CanDoAction of action AddVmTemplate failed. Reasons:VAR__ACTION__
ADD,VAR__TYPE__VM_TEMPLATE,ACTION_TYPE_FAILED_VM_IMAGE_IS_LOCKED
If we don't have the name of the specific image name, we should changed the message to be more general. VM in lock state (probably, one it's disk images is currently locked by asynchronous storage operation).
Checked by creating a VM, installing OS on it, moving the disk to a different domain and then attempting to create a template.
Error message in the web GUI now reads:
Cannot add Template: The disks <disk_name> are locked. Please try again in a few minutes.
Created attachment 582427 [details] log Description of problem: trying to create a template after I started a move disk operation gives an error: Cannot add Template: VM's image is locked. Please try again in a few minutes. since vm is no longer locked for actions that involve only disk operation we should change this error to "Disk X is locked" and not "Vm's image is locked" Version-Release number of selected component (if applicable): si3 How reproducible: 100% Steps to Reproduce: 1. move a disk between two domains 2. try to create template 3. Actual results: only the disk is in locked state (sub tab under vm or disk tab) and vm is does not appear locked. Expected results: Error message should be changed Additional info:log 2012-05-06 13:12:01,719 WARN [org.ovirt.engine.core.bll.AddVmTemplateCommand] (ajp--0.0.0.0-8009-7) [4dd3872c] CanDoAction of action AddVmTemplate failed. Reasons:VAR__ACTION__ ADD,VAR__TYPE__VM_TEMPLATE,ACTION_TYPE_FAILED_VM_IMAGE_IS_LOCKED