Bug 820981 - fix group queries to not return non-committed resources
Summary: fix group queries to not return non-committed resources
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Core Server
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: RHQ 4.5.0
Assignee: John Mazzitelli
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks: 819897 841026
TreeView+ depends on / blocked
 
Reported: 2012-05-11 13:27 UTC by John Mazzitelli
Modified: 2013-09-01 10:05 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
: 841026 (view as bug list)
Environment:
Last Closed: 2013-09-01 10:05:58 UTC
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 819897 0 urgent CLOSED platform recursive groups include non-committed resources as implicit members 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 820432 0 urgent CLOSED platform recursive groups include non-committed resources as implicit members 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 820716 0 urgent CLOSED search bar code for availability querying looks broken 2021-02-22 00:41:40 UTC

Internal Links: 819897 820432 820716

Description John Mazzitelli 2012-05-11 13:27:25 UTC 
this issue was noticed while working on bug 819897 and a response to charles' comment #10 in that BZ:

> we shouldn't *ever* be showing 
> uncommitted resources in the regular inventory. The only place uncommitted 
> resources should appear is in the Import related resource lists.

I did a search in our java code for places where JPQL queries used the .implicitResources and .explicitResources collection and noticed many places where we don't filter out non-committed resources.

This issue is to correct and test those queries. We need good unit tests here because this is going to touch many group queries. Without good unit tests it would require good manual testing in the UI (which we will still do, but we need automated tests as well).
Comment 1 John Mazzitelli 2012-05-11 14:05:02 UTC 
we also need to address bug 820716 since its related.
Comment 2 John Mazzitelli 2012-05-11 20:09:54 UTC 
master commit: 3d1a2e5

this includes several more unit tests.
Comment 3 John Mazzitelli 2012-05-11 20:16:07 UTC 
3f5f02c489179e81d783b49d8270ae869b74d404 fixes a test method name i forgot to change
Comment 4 John Mazzitelli 2012-05-14 15:15:34 UTC 
git commit master: 5c02dfb fixes old unit tests that now have to make sure new resources created are in committed inventory state
Comment 5 Heiko W. Rupp 2013-09-01 10:05:58 UTC 
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.
Note You need to log in before you can comment on or make changes to this bug.