Bug 821165 - Review Request: fcitx-configtool - Gtk configuretool for Fcitx
Summary: Review Request: fcitx-configtool - Gtk configuretool for Fcitx
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-12 16:36 UTC by Liang Suilong
Modified: 2012-06-09 00:05 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-06-09 00:02:28 UTC
Type: Bug
Embargoed:
panemade: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Liang Suilong 2012-05-12 16:36:34 UTC
SPEC: http://liangsuilong.fedorapeople.org/fcitx/fcitx-configtool.spec
SRPM: http://liangsuilong.fedorapeople.org/fcitx/fcitx-configtool-0.4.3-1.fc16.src.rpm
Description: 
Fcitx-config Gtk based configure tool for fcitx.

KDE Version see fcitx-config-kde4 or kcm-fcitx.
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4072583

Comment 1 Parag AN(पराग) 2012-05-15 09:12:56 UTC
Review:-
+ koji scratch build for f18 ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=4072583

+ rpmlint on rpms gave
fcitx-configtool.src: W: spelling-error Summary(en_US) Gtk -> Gk, Gt, Gt k
fcitx-configtool.src: W: spelling-error Summary(en_US) configuretool -> configure tool, configure-tool, reconfiguration
fcitx-configtool.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
fcitx-configtool.src: W: spelling-error %description -l en_US kcm -> kc, km, cm
fcitx-configtool.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-configtool-0.4.3.tar.xz HTTP Error 404: Not Found
fcitx-configtool.x86_64: W: spelling-error Summary(en_US) Gtk -> Gk, Gt, Gt k
fcitx-configtool.x86_64: W: spelling-error Summary(en_US) configuretool -> configure tool, configure-tool, reconfiguration
fcitx-configtool.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure
fcitx-configtool.x86_64: W: spelling-error %description -l en_US kcm -> kc, km, cm
fcitx-configtool.x86_64: W: no-documentation
fcitx-configtool.x86_64: W: no-manual-page-for-binary fcitx-config-gtk3
fcitx-configtool.x86_64: W: no-manual-page-for-binary fcitx-config-gtk
2 packages and 0 specfiles checked; 0 errors, 12 warnings.


+ Source verified with upstream as (sha1sum)
8dd49c8670c6da06c9df9e4476271357593242d4  fcitx-configtool-0.4.3.tar.xz
8dd49c8670c6da06c9df9e4476271357593242d4  ../SOURCES/fcitx-configtool-0.4.3.tar.xz

 
Suggestions:-
1) you may want to remove KDE line in %description as its not at all related to this package.


APPROVED.

Comment 2 Parag AN(पराग) 2012-05-15 09:13:51 UTC
2) Add %doc COPYING README

Comment 3 Liang Suilong 2012-05-17 08:06:03 UTC
New Package SCM Request
=======================
Package Name: fcitx-configtool
Short Description: Gtk configuretool for Fcitx
Owners: liangsuilong
Branches: f15 f16 f17 el6
InitialCC: i18n-team

Comment 4 Gwyn Ciesla 2012-05-17 12:15:53 UTC
Git done (by process-git-requests).

Comment 5 Fedora Update System 2012-05-22 17:08:36 UTC
fcitx-configtool-0.4.3-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/fcitx-configtool-0.4.3-1.fc17

Comment 6 Fedora Update System 2012-05-22 17:08:48 UTC
fcitx-configtool-0.4.3-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/fcitx-configtool-0.4.3-1.fc15

Comment 7 Fedora Update System 2012-05-22 17:08:58 UTC
fcitx-configtool-0.4.3-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/fcitx-configtool-0.4.3-1.fc16

Comment 8 Fedora Update System 2012-05-24 15:34:31 UTC
fcitx-configtool-0.4.3-1.fc17 has been pushed to the Fedora 17 testing repository.

Comment 9 Fedora Update System 2012-05-29 16:55:33 UTC
fcitx-configtool-0.4.3-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/fcitx-configtool-0.4.3-2.fc16

Comment 10 Fedora Update System 2012-05-29 16:55:49 UTC
fcitx-configtool-0.4.3-2.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/fcitx-configtool-0.4.3-2.fc15

Comment 11 Fedora Update System 2012-05-29 16:55:59 UTC
fcitx-configtool-0.4.3-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/fcitx-configtool-0.4.3-2.fc17

Comment 12 Fedora Update System 2012-06-09 00:02:28 UTC
fcitx-configtool-0.4.3-2.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2012-06-09 00:02:49 UTC
fcitx-configtool-0.4.3-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2012-06-09 00:05:13 UTC
fcitx-configtool-0.4.3-2.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.