Red Hat Bugzilla – Bug 821345
Promotions changeset of system template does not solve dependency of product
Last modified: 2014-09-18 11:32:51 EDT
Description of problem: If only a system template is added to a changeset and a promotion is started it will fail to automatically add the required products. Error: "Failed to promote: Cannot promote the changeset '<mychangeset>' because the repo 'RHEL6" does not belong to any promoted product" Version-Release number of selected component (if applicable): System Engine beta6, will verify today with RC
Verified that this is still and issue on RC1
Is this a documentation issue? Is the error appropriate? Only repos/packages can be added to a system template. Should we automatically promote the product or perhaps prompt them or force the user?
Lets change the error messaging to state something to the effect of: "Failed to promote: Please add the RHEL6 product to the changeset if you wish to promote this with the system template" or something similar
https://github.com/Katello/katello/pull/565
Tested on revision: katello-cli-1.1.8-4.el6cf.noarch katello-certs-tools-1.1.8-1.el6cf.noarch candlepin-selinux-0.7.8-1.el6cf.noarch qpid-cpp-server-ssl-0.14-14.el6_2.x86_64 pulp-selinux-server-1.1.12-1.el6cf.noarch katello-glue-pulp-1.1.12-7.el6cf.noarch katello-qpid-broker-key-pair-1.0-1.noarch katello-cli-common-1.1.8-4.el6cf.noarch candlepin-0.7.8-1.el6cf.noarch qpid-cpp-client-ssl-0.14-14.el6_2.x86_64 katello-configure-1.1.9-3.el6cf.noarch katello-glue-candlepin-1.1.12-7.el6cf.noarch katello-candlepin-cert-key-pair-1.0-1.noarch candlepin-tomcat6-0.7.8-1.el6cf.noarch pulp-common-1.1.12-1.el6cf.noarch qpid-cpp-server-0.14-14.el6_2.x86_64 katello-selinux-1.1.1-1.el6cf.noarch katello-all-1.1.12-7.el6cf.noarch python-qpid-0.14-7.el6_2.noarch python-isodate-0.4.4-4.pulp.el6.noarch qpid-cpp-client-0.14-14.el6_2.x86_64 pulp-1.1.12-1.el6cf.noarch katello-common-1.1.12-7.el6cf.noarch katello-1.1.12-7.el6cf.noarch katello-qpid-client-key-pair-1.0-1.noarch m2crypto-0.21.1.pulp-7.el6.x86_64 python-oauth2-1.5.170-2.pulp.el6.noarch mod_wsgi-3.3-3.pulp.el6.x86_64 Message is changed, but it shows '#' instead of name of product. So it shows like this: "Please add '#' product to the changeset 'chzoo' if you wish to promote repository 'zoo' with it" Maybe this is because in promotion_changeset.rb code: "raise _("Please add '%s' product to the changeset '%s' if you wish to promote repository '%s' with it.") % [repo.product, self.name, repo.name]" it should be "repo.product.name" instead of "repo.product" in message param value.
Reassigning to Dmitri. This is oneliner ^ :-)
fixed in ea80c52
Verified on revision: katello-glue-candlepin-1.1.12-12.el6cf.noarch katello-candlepin-cert-key-pair-1.0-1.noarch katello-cli-1.1.8-6.el6cf.noarch katello-configure-1.1.9-6.el6cf.noarch katello-1.1.12-12.el6cf.noarch katello-qpid-client-key-pair-1.0-1.noarch katello-certs-tools-1.1.8-1.el6cf.noarch katello-glue-pulp-1.1.12-12.el6cf.noarch katello-selinux-1.1.1-1.el6cf.noarch katello-qpid-broker-key-pair-1.0-1.noarch katello-cli-common-1.1.8-6.el6cf.noarch katello-common-1.1.12-12.el6cf.noarch katello-agent-1.1.2-1.el6cf.noarch Now it shows correct message with name of product.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2012-1543.html
getting rid of 6.0.0 version since that doesn't exist