Bug 821406 - Review Request: eiskaltdcpp - QT Direct Connect client
Review Request: eiskaltdcpp - QT Direct Connect client
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
: 676943 (view as bug list)
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-14 07:50 EDT by Vasiliy Glazov
Modified: 2016-06-24 03:57 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Vasiliy Glazov 2012-05-14 07:50:18 EDT
Spec URL: https://github.com/RussianFedora/eiskaltdcpp/blob/master/eiskaltdcpp.spec
Patches URL: https://github.com/RussianFedora/eiskaltdcpp
SRPM URL: http://koji.russianfedora.ru/packages/eiskaltdcpp/2.2.6/5.fc17.R/src/eiskaltdcpp-2.2.6-5.fc17.R.src.rpm

Description: 
EiskaltDC++ is a program the uses the Direct Connect protocol. It is compatible
with other DC clients, such as the original DC from Neomodus, DC++ and
derivatives. EiskaltDC++ also interoperates with all common DC hub software.

I am need a sponsor for this package.
Comment 2 Jason Tibbitts 2013-05-20 14:14:00 EDT
I am triaging old review tickets.  I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.

This failed to build for me: http://koji.fedoraproject.org/koji/taskinfo?taskID=5401556
Comment 5 Veaceslav Mindru 2013-07-29 11:35:21 EDT
Privet Vasiliy,

Should this be corrected and not be depended on user when installing  SRPM? 

[mindruv@localhost Downloads]$ rpm -ivh /tmp/eiskaltdcpp-2.2.8-1.fc20.R.src.rpm 
Updating / installing...
   1:eiskaltdcpp-2.2.8-1.fc20.R       ################################# [100%]
warning: user mockbuild does not exist - using root
warning: group mockbuild does not exist - using root
warning: user mockbuild does not exist - using root
warning: group mockbuild does not exist - using root
[mindruv@localhost Downloads]$ 


VM
Comment 6 Veaceslav Mindru 2013-07-29 11:51:37 EDT
Privet Vasiliy ,

failed to build for me.


/usr/bin/cmake -E cmake_progress_report /home/mindruv/rpmbuild/BUILD/eiskaltdcpp-2.2.8/CMakeFiles  20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78
[100%] Built target eiskaltdcpp-qt
make[1]: Leaving directory `/home/mindruv/rpmbuild/BUILD/eiskaltdcpp-2.2.8'
make: *** [all] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.HKldPs (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.HKldPs (%build)
[mindruv@localhost rpmbuild]$
Comment 7 Vasiliy Glazov 2013-07-29 12:44:23 EDT
How you build it? Please attach full log.
Comment 8 Veaceslav Mindru 2013-07-29 14:23:58 EDT
Hello,

after installing all devel packages required i corrupted my libraries :). Everything stopped working. Had to perform update of all packages troubleshooting from init3 was not very convenient and time consuming. 

I will setup a new Fedora18 VM machine and will try to provide an reproduction scenario. 


VM
Comment 9 Veaceslav Mindru 2013-07-29 14:24:38 EDT
One more thing build was done with default rpmbuild options.
Comment 10 Vasiliy Glazov 2013-07-31 02:01:05 EDT
Veaceslav, problem still present? show full build log.
Comment 11 Veaceslav Mindru 2013-07-31 02:33:32 EDT
Hello Vasiliy, i did not have time to build it so far.I will try today and will let you know. 

VM
Comment 12 Christopher Meng 2013-08-30 01:57:40 EDT
1. 2.2.9 is released.

2. Where is zlib-devel/pcre-devel/libattr-devel/libcanberra-gtk3/xmlrpc-c-c++/miniupnpc-devel?

3.  qt-devel >= 4.6.0 should be qt4-devel

4. %description qt
Qt-based graphical interface

%description gtk
Gtk interface based on code of FreeDC++ and LinuxDC++

Missing dot "." .

5. rm -rf %{buildroot}/usr/share/%{name}/examples/*.php

desktop-file-validate %{buildroot}/%{_datadir}/applications/*qt*.desktop

Why don't you use macro?

And, %{buildroot}/%{_datadir} should be %{buildroot}%{_datadir} as %{_datadir} eq /usr/share, already has the slash.

6. Requires:       %{name}-gui = %{version}-%{release}

Auh, shouldn't it be

Requires:       %{name}-gui%{?_isa} = %{version}-%{release}?

7. Since gtk/qt subpackage requires main package, I think you can ship doc once.

So remove the %doc AUTHORS COPYING in 2 subpackages.
Comment 14 Ivan Romanov 2013-11-16 04:22:02 EST
Remove "Group: Applications/Internet". It is not used anymore.
Comment 16 Ivan Romanov 2013-11-16 05:00:02 EST
Rename all QT to Qt. QT is not correct.
Comment 17 Ivan Romanov 2013-11-16 05:17:55 EST
In description use "GTK+ 3" not Gtk and not GTK3.
Probably gtk subpackage should be renamed to gtk3 (because it uses GTK+ 3 library and requires gtk3 package)
Comment 18 Ivan Romanov 2013-11-16 05:19:40 EST
Why you don't use cli-xmlrpc
Comment 19 Ivan Romanov 2013-11-16 05:56:56 EST
drop -DCMAKE_BUILD_TYPE=RelWithDebInfo. %cmake allready has CFLAGS and CXXFLAGS
Comment 20 Vasiliy Glazov 2013-11-21 03:31:25 EST
Spec URL: https://raw.github.com/RussianFedora/eiskaltdcpp/master/eiskaltdcpp.spec
SRPM URL: http://koji.russianfedora.ru/koji/getfile?taskID=91431&name=eiskaltdcpp-2.2.9-2.fc21.R.src.rpm

Removed Group, corrected descriptions, added xmlrpc, dropped -DCMAKE_BUILD_TYPE=RelWithDebInfo.
Comment 22 Ivan Romanov 2013-11-24 06:10:14 EST
Sources use various licenses (BSD, GPLv2+ and GPLv3+). You must clarify this in spec.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario

Also EiskaltDC++ uses bunlded miniupnpc and jsoncpp.
These packages allready is in Fedora. You must explicity remove them in %prep stage
https://fedoraproject.org/wiki/Packaging:Treatment_Of_Bundled_Libraries#Packages_with_Bundled_Libraries
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
Comment 25 Parag AN(पराग) 2015-09-23 02:21:16 EDT
*** Bug 676943 has been marked as a duplicate of this bug. ***
Comment 27 Vasiliy Glazov 2016-06-24 03:57:09 EDT
Spec URL: https://raw.github.com/RussianFedora/eiskaltdcpp/master/eiskaltdcpp.spec
SRPM URL: http://koji.russianfedora.pro/kojifiles/work/tasks/1883/81883/eiskaltdcpp-2.2.10-2.fc25.src.rpm

Change BR to pkgconfig, use %license macro, clean spec.

Note You need to log in before you can comment on or make changes to this bug.