This service will be undergoing maintenance at 20:00 UTC, 2017-04-03. It is expected to last about 30 minutes
Bug 82185 - poor quality source code
poor quality source code
Status: CLOSED WONTFIX
Product: Red Hat Linux
Classification: Retired
Component: kpppload (Show other bugs)
8.0
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ngo Than
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2003-01-19 05:09 EST by d.binderman
Modified: 2007-04-18 12:50 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2004-12-18 14:23:25 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description d.binderman 2003-01-19 05:09:35 EST
From Bugzilla Helper:
User-Agent: Mozilla/4.6 [en-gb]C-CCK-MCD NetscapeOnline.co.uk  (Win98; I)

Description of problem:

Hello there,

I just tried to compile package kpppload-1.04-43 from Redhat 8.0

The compiler said

Options.cpp:98: warning: taking address of temporary
Options.cpp:103: warning: taking address of temporary

Here is an untested patch to shut up the compiler

*** ./kpppload/Options.cpp.old	2003-01-12 10:31:09.000000000 +0000
--- ./kpppload/Options.cpp	2003-01-12 10:32:32.000000000 +0000
***************
*** 95,106 ****
  
  QColor Options::getRxColor()
  {
!     return _config->readColorEntry( "rxColor", &QColor( "red" ) );
  }
  
  QColor Options::getTxColor()
  {
!     return _config->readColorEntry( "txColor", &QColor( "darkblue" ) );
  }
  
  void Options::setShowTxRate( bool b )
--- 95,110 ----
  
  QColor Options::getRxColor()
  {
!     QColor tmp( "red");
! 
!     return _config->readColorEntry( "rxColor", & tmp);
  }
  
  QColor Options::getTxColor()
  {
!     QColor tmp( "darkblue" );
! 
!     return _config->readColorEntry( "txColor", & tmp);
  }
  
  void Options::setShowTxRate( bool b )

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. compile the program
2.
3.
    

Additional info
Comment 1 Marcin Garski 2004-12-18 14:23:25 EST
Thanks for the bug report. Red Hat Linux 8.0 is no longer maintained
by Red Hat. KPPPLoad is no longer included in current releases, either.

Note You need to log in before you can comment on or make changes to this bug.