Bug 821890 - Review Request: trac-sphinx-plugin - Basic tasks to manage Sphinx documentation in Trac
Summary: Review Request: trac-sphinx-plugin - Basic tasks to manage Sphinx documentati...
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2012-05-15 16:54 UTC by Andrea Veri
Modified: 2019-02-28 12:07 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2019-02-28 12:07:45 UTC
Type: ---
kevin: fedora-review+
gwync: fedora-cvs+

Attachments (Terms of Use)

Description Andrea Veri 2012-05-15 16:54:54 UTC
Spec URL: http://averi.fedorapeople.org/RPMs/trac-sphinx-plugin/trac-sphinx-plugin.spec
SRPM URL: http://averi.fedorapeople.org/RPMs/trac-sphinx-plugin/trac-sphinx-plugin-0.2.1-20120515.hge021e691af84.fc16.src.rpm
Description: A trac plugin that implements basic tasks to manage Sphinx documentation in Trac.

Comment 1 Kevin Fenzi 2012-05-15 19:09:04 UTC
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (BSD)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
(Sources do match up, md5 difference is due to timestamps)
87ae6e18ac9b477df50ea8df762c0ea1  trac-sphinx-plugin-
93fb5087f811a3f4d9d02528e31069e4  trac-sphinx-plugin-

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.


OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have sane scriptlets. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin


1. rpmlint says: 

trac-sphinx-plugin.src: W: invalid-url Source0: trac-sphinx-plugin-
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

Can be ignored. 

I see no blockers here, so this package is APPROVED.

Comment 2 Andrea Veri 2012-05-16 10:09:45 UTC
New Package SCM Request
Package Name: trac-sphinx-plugin 
Short Description: Basic tasks to manage Sphinx documentation in Trac
Owners: averi kevin
Branches: f17 el5 el6
InitialCC: averi kevin

Comment 3 Gwyn Ciesla 2012-05-16 13:16:07 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2012-05-20 16:25:24 UTC
trac-sphinx-plugin-0.2.1-20120515.hge021e691af84.el6 has been submitted as an update for Fedora EPEL 6.

Comment 5 Fedora Update System 2012-05-20 17:57:48 UTC
trac-sphinx-plugin-0.2.1-20120515.hge021e691af84.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 6 Kamil Páral 2019-02-28 12:07:45 UTC
The package is in Fedora, I believe this should be closed.

Note You need to log in before you can comment on or make changes to this bug.