Bug 822068
| Summary: | libvirtd will crash when hotplug attah-disk to guest | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Huang Wenlong <whuang> | ||||||
| Component: | libvirt | Assignee: | Peter Krempa <pkrempa> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 6.4 | CC: | acathrow, cwei, dallan, dyasny, dyuan, gsun, mzhan, rwu, weizhan, zpeng | ||||||
| Target Milestone: | rc | ||||||||
| Target Release: | 6.4 | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | libvirt-0.9.13-3.el6 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-02-21 07:13:10 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Huang Wenlong
2012-05-16 09:02:09 UTC
Created attachment 584905 [details]
libvirtd crash log
Hi Huang, could you please provide a full backtrace of the crashed daemon? I'm not able to reproduce this. Peter Created attachment 585716 [details]
gdb backtrace
Hi,Peter
I attached the gdb all backtrace ,thanks .
Wenlong
Fixed upstream:
commit 0f4660c8787cc41fe67f869984c0ae11d680037e
Author: Peter Krempa <pkrempa>
Date: Thu Jun 14 10:29:36 2012 +0200
qemu: Fix off-by-one error while unescaping monitor strings
While unescaping the commands the commands passed through to the monitor
function qemuMonitorUnescapeArg() initialized lenght of the input string
to strlen()+1 which is fine for alloc but not for iteration of the
string.
This patch fixes the off-by-one error and drops the pointless check for
a single trailing slash that is automaticaly handled by the default
branch of switch.
I can reproduce this with:
libvirt-0.9.11.3-1.el7.x86_64
qemu-kvm-1.0-17.1.el7.x86_64
verify with:
libvirt-0.9.13-3.el6.x86_64
step:
1: run cmd:
#for i in {a..z}; do virsh attach-disk $guest_name /dev/zero vd$i; done
error: Failed to attach disk
error: operation failed: target vda already exists
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
Disk attached successfully
error: Failed to attach disk
error: internal error No more available PCI addresses
#virsh list --all
Id Name State
----------------------------------------------------
3 rhel6.3rcqcow2 running
- rhel6.3c shut off
- rhel6.3rc shut off
- rhel6u2 shut off
libvirt not crash, verification passed.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2013-0276.html |