Bug 822830 - specifying invalid ip_address as value for auth.allow/reject option is accepted
Summary: specifying invalid ip_address as value for auth.allow/reject option is accepted
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: cli
Version: mainline
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
Assignee: Avra Sengupta
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 849290
TreeView+ depends on / blocked
 
Reported: 2012-05-18 09:54 UTC by Shwetha Panduranga
Modified: 2013-07-24 17:39 UTC (History)
2 users (show)

Fixed In Version: glusterfs-3.4.0
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 849290 (view as bug list)
Environment:
Last Closed: 2013-07-24 17:39:03 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Shwetha Panduranga 2012-05-18 09:54:01 UTC 
Description of problem:
Invalid IP address such as "192.*..*", "a.a." is accepted as valid ip_address. 

Version-Release number of selected component (if applicable):
3.3.0qa41

How reproducible:
often

Steps to Reproduce:
1.create a replicate volume
2.gluster volume set <volume_name> nfs.rpc-auth-reject 192.*..*
3.gluster volume set <volume_name> nfs.rpc-auth-reject a.a.
  
Actual results:
set volume successful

Expected results:
set volume should be unsuccessful as we have specified the invalid ip address
Comment 1 Amar Tumballi 2012-10-31 11:53:27 UTC 
As of today, we are taking input for these options as regex (of fnmatch()), hence we don't validate a lot during CLI command itself. I think it makes sense to treat  this as an enhancement.
Comment 2 Vijay Bellur 2013-02-26 03:52:44 UTC 
CHANGE: http://review.gluster.org/4579 (libglusterfs: Fixed valid_ipv4_address and valid_host_name) merged in master by Anand Avati (avati)
Note You need to log in before you can comment on or make changes to this bug.