Spec URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-Routing.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-Routing-2.0.14-1.fc16.src.rpm Description: The Routing Component maps an HTTP request to a set of configuration variables.
Updates per comments in bug 823043 - Removed BuildRoot - Changed php require to php-common - Added the following requires based on phpci results: php-libxml, php-pcre, php-spl, php-tokenizer - Removed %defattr from %files section SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-Routing.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-Routing-2.0.14-2.fc16.src.rpm
Update per https://bugzilla.redhat.com/show_bug.cgi?id=823041#c5 - Moved documentation to correct location SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-Routing.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-Routing-2.0.14-3.fc16.src.rpm
Updated to upstream version 2.0.15 & updates per bug #817303 - Removed "BuildRequires: php-pear >= 1:1.4.9-1.2" - Updated %prep section - Removed cleaning buildroot from %install section - Removed documentation move from %install section (fixed upstream) - Removed %clean section - Updated %doc in %files section SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-Routing.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-Routing-2.0.15-1.fc16.src.rpm
Issue: XSD file installed as doc, but referenced by code. -- XSD file -- Symfony/Component/Routing/Loader/schema/routing/routing-1.0.xsd -- Code -- protected function validate(\DOMDocument $dom) { $location = __DIR__.'/schema/routing/routing-1.0.xsd'; $current = libxml_use_internal_errors(true); if (!$dom->schemaValidate($location)) { throw new \InvalidArgumentException(implode("\n", $this->getXmlErrors())); } libxml_use_internal_errors($current); } See original finding of this issue at https://bugzilla.redhat.com/show_bug.cgi?id=823046#c8
(In reply to comment #4) > -- Code -- from Routing/Loader/XmlFileLoader.php
Added optional requires - Added php-pear(%{pear_channel}/Config) require - Added php-pear(%{pear_channel}/Yaml) require - Removed ownership for directories already owned by required packages Update per comment #4 - Fix package.xml for *.xsd file issue SPEC URL: http://people.redhat.com/~siwinski/rpmbuild/SPECS/php-symfony2-Routing.spec SRPM URL: http://people.redhat.com/~siwinski/rpmbuild/SRPMS/php-symfony2-Routing-2.0.15-3.fc17.src.rpm
Created attachment 593975 [details] php-symfony2-Routing-review.txt Generated by fedora-review 0.1.3
No issue detected. == APPROVED ==
New Package SCM Request ======================= Package Name: php-symfony2-Routing Short Description: Symfony2 Routing Component Owners: siwinski Branches: f16 f17 el6 InitialCC:
Sorry, but I have miss that one /usr/share/pear/Symfony/Component/Routing/Loader/AnnotationClassLoader.php use Doctrine\Common\Annotations\Reader So you probably need php-doctrine-DoctrineCommon (not yet packaged). So please 1/ assure this is an optionnal dep 2/ consider submitting a review for this package.
Git done (by process-git-requests).
(In reply to comment #10) > Sorry, but I have miss that one > > /usr/share/pear/Symfony/Component/Routing/Loader/AnnotationClassLoader.php > use Doctrine\Common\Annotations\Reader > > So you probably need php-doctrine-DoctrineCommon (not yet packaged). > > So please > 1/ assure this is an optionnal dep > 2/ consider submitting a review for this package. Same response as https://bugzilla.redhat.com/show_bug.cgi?id=823075#c6
php-symfony2-Routing-2.0.15-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-symfony2-Routing-2.0.15-3.fc17
php-symfony2-Routing-2.0.15-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-symfony2-Routing-2.0.15-3.fc16
php-symfony2-Routing-2.0.15-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-symfony2-Routing-2.0.15-3.el6
php-symfony2-Routing-2.0.15-3.fc16 has been pushed to the Fedora 16 testing repository.
php-symfony2-Routing-2.0.15-3.fc16 has been pushed to the Fedora 16 stable repository.
php-symfony2-Routing-2.0.15-3.fc17 has been pushed to the Fedora 17 stable repository.
php-symfony2-Routing-2.0.15-3.el6 has been pushed to the Fedora EPEL 6 stable repository.