Spec URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-Validator.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-Validator-2.0.14-1.fc16.src.rpm Description: Symfony2 Validator Component.
Updates per comments in bug 823043 - Removed BuildRoot - Changed php require to php-common - Added the following requires based on phpci results: php-ctype, php-date, php-libxml, php-mbstring, php-pcre, php-simplexml, php-spl, php-pecl-apc - Removed %defattr from %files section SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-Validator.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-Validator-2.0.14-2.fc16.src.rpm
Update per https://bugzilla.redhat.com/show_bug.cgi?id=823041#c5 - Moved documentation to correct location SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-Validator.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-Validator-2.0.14-3.fc16.src.rpm
Update per https://bugzilla.redhat.com/show_bug.cgi?id=823071#c5 - Added missing php-intl require SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-Validator.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-Validator-2.0.14-4.fc16.src.rpm
Updated to upstream version 2.0.15 & updates per bug #817303 - Removed "BuildRequires: php-pear >= 1:1.4.9-1.2" - Updated %prep section - Removed cleaning buildroot from %install section - Removed documentation move from %install section (fixed upstream) - Removed %clean section - Updated %doc in %files section SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-Validator.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-Validator-2.0.15-1.fc16.src.rpm
Issue: XSD file installed as doc, but referenced by code. -- XSD file -- Symfony/Component/Validator/Mapping/Loader/schema/dic/constraint-mapping/constraint-mapping-1.0.xsd -- Code (from Symfony/Component/Validator/Mapping/Loader/XmlFileLoader.php) -- protected function parseFile($file) { $dom = new \DOMDocument(); libxml_use_internal_errors(true); if (!$dom->load($file, defined('LIBXML_COMPACT') ? LIBXML_COMPACT : 0)) { throw new MappingException(implode("\n", $this->getXmlErrors())); } if (!$dom->schemaValidate(__DIR__.'/schema/dic/constraint-mapping/constraint-mapping-1.0.xsd$ throw new MappingException(implode("\n", $this->getXmlErrors())); } $dom->validateOnParse = true; $dom->normalizeDocument(); libxml_use_internal_errors(false); return simplexml_import_dom($dom); } See original finding of this issue at https://bugzilla.redhat.com/show_bug.cgi?id=823046#c8
Added optional requires - Added php-pear(%{pear_channel}/HttpFoundation) require - Added php-pear(%{pear_channel}/Yaml) require - Removed ownership for directories already owned by required packages Update per comment #5 - Fix package.xml for *.xsd file issue SPEC URL: http://people.redhat.com/~siwinski/rpmbuild/SPECS/php-symfony2-Validator.spec SRPM URL: http://people.redhat.com/~siwinski/rpmbuild/SRPMS/php-symfony2-Validator-2.0.15-3.fc17.src.rpm
Created attachment 593976 [details] php-symfony2-Validator-review.txt Generated by fedora-review 0.1.3
Just need to fix the apc requirement. Note: this is not a minor dependency, as it can change the web server user experience. Of couse, it should improved perf. But could also breaks some code. For exemple, APC 3.1.10 breaks symfony2 framework ;) Of course, such issue will have to be fixed ;) => https://admin.fedoraproject.org/updates/php-pecl-apc-3.1.10-2.fc17 Of course, this still your choice, I just want you to be aware of this. In all case, if you keep it, please change to Requires: php-pecl(APC)
(In reply to comment #8) Agreed. I will remove the dependency and re-post SPEC and SRPM.
Sorry, but I have miss that one /usr/share/pear/Symfony/Component/Validator/ValidatorFactory.php and /usr/share/pear/Symfony/Component/Validator/Mapping/Loader/AnnotationLoader.php use Doctrine\Common\Annotations\Reader So you probably need php-doctrine-DoctrineCommon (not yet packaged). So please 1/ assure this is an optionnal dep 2/ consider submitting a review for this package.
(In reply to comment #10) > Sorry, but I have miss that one > > /usr/share/pear/Symfony/Component/Validator/ValidatorFactory.php and > /usr/share/pear/Symfony/Component/Validator/Mapping/Loader/AnnotationLoader. > php > use Doctrine\Common\Annotations\Reader > > So you probably need php-doctrine-DoctrineCommon (not yet packaged). > > So please > 1/ assure this is an optionnal dep > 2/ consider submitting a review for this package. Almost the same response as https://bugzilla.redhat.com/show_bug.cgi?id=823075#c6. However, v2.0.15 composer lists "DoctrineCommon" as "require" but it moved to "suggest" in v2.1.0BETA1. No change in PEAR dependencies between those versions. It still appears that this dependency is optional though. I plan on packaging DoctrineCommon soon. If you feel this is a blocker, we can wait on this package (and Form package and therefore Security package because of their dependencies).
AS this is only an optional dep., just fix the APC dependency, I will approve this package. Optional could be added later.
Sorry for the noise...
Updates per comment #12 - Removed APC require - Updated %description SPEC URL: http://siwinski.fedorapeople.org/rpmbuild/SPECS/php-symfony2-Validator.spec SRPM URL: http://siwinski.fedorapeople.org/rpmbuild/SRPMS/php-symfony2-Validator-2.0.15-4.fc17.src.rpm
== APPROVED ==
New Package SCM Request ======================= Package Name: php-symfony2-Validator Short Description: Symfony2 Validator Component Owners: siwinski Branches: f16 f17 el6 InitialCC:
Git done (by process-git-requests).
php-symfony2-Validator-2.0.15-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-symfony2-Validator-2.0.15-4.fc17
php-symfony2-Validator-2.0.15-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-symfony2-Validator-2.0.15-4.el6
php-symfony2-Validator-2.0.15-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-symfony2-Validator-2.0.15-4.fc16
php-symfony2-Validator-2.0.15-4.fc17 has been pushed to the Fedora 17 testing repository.
php-symfony2-Validator-2.0.15-4.fc17 has been pushed to the Fedora 17 stable repository.
php-symfony2-Validator-2.0.15-4.fc16 has been pushed to the Fedora 16 stable repository.
php-symfony2-Validator-2.0.15-4.el6 has been pushed to the Fedora EPEL 6 stable repository.