Bug 82316 - #79218 - Spanish translation missing for desktop menu
Summary: #79218 - Spanish translation missing for desktop menu
Alias: None
Product: Red Hat Public Beta
Classification: Retired
Component: redhat-config-printer
Version: phoebe
Hardware: i386
OS: Linux
Target Milestone: ---
Assignee: Tim Waugh
QA Contact: David Lawrence
: 84362 (view as bug list)
Depends On:
Blocks: 79579
TreeView+ depends on / blocked
Reported: 2003-01-21 07:31 UTC by Paul Gampe
Modified: 2013-01-10 21:33 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2003-04-01 12:40:42 UTC

Attachments (Terms of Use)
Patch to use intltool (4.72 KB, patch)
2003-03-19 13:00 UTC, Miloslav Trmac
no flags Details | Diff

Description Paul Gampe 2003-01-21 07:31:08 UTC
Description of problem: 
The desktop menu entry for redhat-config-printer is not translated, as reported in #79218. 
Version-Release number of selected component (if applicable): 
How reproducible: 
Steps to Reproduce: 
1. Install es_ES locale 
2. Login to desktop 
Actual results: 
English menu item 
Expected results: 
Spanish translation 
Additional info: 
I could not find the desktop item for translation on elvis .

Comment 1 Tim Waugh 2003-01-21 11:49:31 UTC
It's in printconf/printconf-gui.desktop.

Comment 2 Tim Waugh 2003-01-27 13:54:53 UTC
Let me know what I need to do here.

Comment 3 Paul Gampe 2003-01-28 07:07:21 UTC
Hi Tim, you could use the intltool* set to extract the .desktop strings and put them into the .po 
files for translation, or look through the strings in the .po files to see if translations for them 
already exist that you could c'n'p into the .desktop file. 

Comment 4 Tim Waugh 2003-01-28 12:33:09 UTC
Patch from bug #79745 was broken.  Should be fixed in
redhat-config-printer-0.6.42-1.  Please confirm.

Comment 5 Tim Waugh 2003-01-28 12:33:59 UTC
Oops, that was intended for a different bug.

Comment 6 Tim Waugh 2003-02-14 23:57:50 UTC
*** Bug 84362 has been marked as a duplicate of this bug. ***

Comment 7 Tim Waugh 2003-03-04 16:45:55 UTC
Not sure how to use intltool*.  Any examples I could look at elsewhere?

Comment 8 Miloslav Trmac 2003-03-19 13:00:51 UTC
Created attachment 90662 [details]
Patch to use intltool

Usually, intltool is used together with autoconf; intltoolize is run from
autogen.sh and the distributed tarball contains intltool-*.in, which are
converted to intltool-* by configure. This means that the tarball is not
dependent on whether does the user have intltool installed.

This is not much of a concern for printconf ;-), so the attached patch
just calls /usr/bin/intltool-*. It just converts the system to use intltool
and makes the printconf-gui.desktop file translatable. After building the
original package and package with this patch applied, there are no differences
in *.py or *.mo files.

(It also fixes a typo in the Makefile: verison -> version)

* You'll need to add intltool to Buildrequires: in printconf.spec
* This patch does not include the regenerated *.po{,t} files. After running
  make -C po update-po, you should get a new set which has all the strings
  the original files had, plus about 30 new strings. Two of them come from
  printconf-gui.desktop.in and should be translated (or merged from previous
  file, see below).
  The others are caused by the
  fact that *.py files contain _N() markers, which were not found using the
  previous xgettext invocation. It seems most of the markers should not be
  there (definitely the _N('') ) at all.
* printconf-gui.desktop is generated from printconf-gui.desktop.in
  by intltool-merge. The old translations from printconf-gui.desktop
  were REMOVED and will have to be manually merged to newly generated *.po
* This should also fix your libglade-xgettext problems, intltool supports
  *.glade natively. I have added gui/redhat-config-printer.glade in POTFILES
  and removed the commented-out rule for redhat-config-printer.glade.str.

Comment 9 Tim Waugh 2003-04-01 12:40:42 UTC
Thanks a lot!  Patch applied in redhat-config-printer-0.6.50-1.

Note You need to log in before you can comment on or make changes to this bug.