Red Hat Bugzilla – Bug 823176
Line numbers in file annotation are not in sync with the actual lines.
Last modified: 2012-10-02 04:03:17 EDT
Description of problem:
Please refer the attached screen shot. When viewing a file the line numbers in the file annotation section are not in sync with the actual line numbers. For eg in the screen shot, line number 15 is shown against what is actually line number 16.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
Created attachment 585598 [details]
I think there is a problem with fonts setup in the application and in the system. Please open a bug report in upstream directly at http://libre.tibirna.org/projects/qgit
I've tried all the combos of monospace fonts I could find. It is not an issue of fonts setup. The problem is in how the file display and file annotation is set up. Choosing a magic font "works" only if the font metrics are somehow identical with all font features. The annotations and line numbers are in a shaded (grey) font and the file itself is black. Whatever goes on in the rendering of each whether it is rounding errors, aliasing funnies or ??? getting the right magic is just dumb luck.
To show how bad it is off, If I display a 1233 line file, that last line is somewhere between lines 1164 and 1165 in the annotations/line numbers column. This makes this very useful feature (nicer than gitk et al) useless.
This feature needs to be re-thought. What needs to be done is to replace this canvas, text box, or whatever widget it is with a "table". I may not be using the right terms but this pane has to be a two/three column, N row table. The rendering will then be rendering cells and who cares what the font characteristics are.
Elbin, I checked out issue 20 over on their site and the analysis is close but missing what I noted above. I don't have an acct there so could you poke them and pass this on? It is annoying enough that i'd fix it myself except I'm up to my ears in getting an nfs server to work.
Created attachment 612641 [details]
Could you, please, test this patch. It seems to work for me on fedora 17.
(In reply to comment #5)
> Created attachment 612641 [details]
> Proposed fix
> Could you, please, test this patch. It seems to work for me on fedora 17.
Many thanks, it fixes the issue also for me, going to prepare an official update.
qgit-2.4-4.fc16 has been submitted as an update for Fedora 16.
qgit-2.4-4.fc18 has been submitted as an update for Fedora 18.
qgit-2.4-4.fc17 has been submitted as an update for Fedora 17.
qgit-2.4-4.el6 has been submitted as an update for Fedora EPEL 6.
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing qgit-2.4-4.fc18'
as soon as you are able to.
Please go to the following url:
then log in and leave karma (feedback).
Tested 2.4-4.fc16.x86_64. Works. I'm ok with closing this.
qgit-2.4-4.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
Will the f16/f17/el6 versions hit the stable repo like f18 did?
(In reply to comment #14)
> Will the f16/f17/el6 versions hit the stable repo like f18 did?
All should out now, thanks for reminder.