Bug 823226 - Review Request: sqlheavy - GObject wrapper for SQLite [NEEDINFO]
Review Request: sqlheavy - GObject wrapper for SQLite
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-19 22:24 EDT by Adrian Alves
Modified: 2013-11-21 10:51 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
tibbs: needinfo? (aalves)


Attachments (Terms of Use)

  None (edit)
Description Adrian Alves 2012-05-19 22:24:07 EDT
Spec URL: http://alvesadrian.fedorapeople.org/sqlheavy.spec
SRPM URL: http://alvesadrian.fedorapeople.org/sqlheavy-0.1.1-1.fc16.src.rpm
Description: SQLHeavy is a wrapper on top of SQLite with a GObject-based interface
Fedora Account System Username: alvesadrian
Comment 1 Michael Scherer 2012-05-20 17:44:45 EDT
Hi,

a few comment on the spec  :
- you should have a -devel subpackage for developpement related files ( .h, .pc, etc )
https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages


- I am not sure, but I think there was some discussion regarding the place of vala files. However, that's not in the policy yet, so I would just suggest to keep a eye on it

- the package do not compile on rawwhide ( it does on f17 however ). Not sure why, but you can check with mock.

- the license tag is invalid 
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_Short_Names

- there is no ldconfig call in %post, and that's kinda required
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries
Comment 2 Adrian Alves 2012-05-20 22:21:56 EDT
(In reply to comment #1)
> Hi,
> 
> a few comment on the spec  :
> - you should have a -devel subpackage for developpement related files ( .h,
> .pc, etc )
> https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
> 
> 
> - I am not sure, but I think there was some discussion regarding the place
> of vala files. However, that's not in the policy yet, so I would just
> suggest to keep a eye on it
> 
> - the package do not compile on rawwhide ( it does on f17 however ). Not
> sure why, but you can check with mock.
> 
> - the license tag is invalid 
> https://fedoraproject.org/wiki/Packaging:
> LicensingGuidelines#Valid_License_Short_Names
> 
> - there is no ldconfig call in %post, and that's kinda required
> https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Shared_libraries
I added sub-package devel but not sure if that is correct:
Spec URL: http://alvesadrian.fedorapeople.org/sqlheavy.spec
SRPM URL: http://alvesadrian.fedorapeople.org/sqlheavy-0.1.1-2.fc16.src.rpm

By the way fixed the license tag and added the ldconfig in post and postun
Comment 3 Thomas Moschny 2012-05-26 07:43:26 EDT
Your %files section needs a bit of rework. See http://thm.fedorapeople.org/sqlheavy/sqlheavy.spec .

Also, rpmlint warns about mixed tabs and spaces, maybe you want to recheck that and either use tabs or spaces for indention.
Comment 4 Adrian Alves 2012-05-26 08:18:02 EDT
(In reply to comment #3)
> Your %files section needs a bit of rework. See
> http://thm.fedorapeople.org/sqlheavy/sqlheavy.spec .
> 
> Also, rpmlint warns about mixed tabs and spaces, maybe you want to recheck
> that and either use tabs or spaces for indention.

Added ur modifications:
Spec URL: http://alvesadrian.fedorapeople.org/sqlheavy.spec
SRPM URL: http://alvesadrian.fedorapeople.org/sqlheavy-0.1.1-3.fc16.src.rpm
Comment 5 Jason Tibbitts 2013-05-20 21:25:21 EDT
I am triaging old review tickets.  I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.

This fails to build for me.  A scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5403710

Note You need to log in before you can comment on or make changes to this bug.