Red Hat Bugzilla – Bug 823338
Review Request: rubygem-moneta - unified interface for key/value stores
Last modified: 2016-01-04 00:50:39 EST
Spec URL: https://raw.github.com/jcourteau/rubygems-rpms/master/fc17/rubygem-moneta/rubygem-moneta.spec
SRPM URL: http://rpms.courteau.org/fedora/rubygem-moneta-0.6.0-1.fc17.src.rpm
Description: A unified (ruby) interface to key/value stores
This is part of a set of dependencies for rubygem-chef. I've got about 14 packages to add, all ruby gems, and am looking for a sponsor. Several of the packages were previously in Fedora (F11 and F12), but were removed due to lack of a maintainer.
Please note that rubygem-moneta was already in Fedora: https://admin.fedoraproject.org/pkgdb/acls/name/rubygem-moneta but has been retired.
Since Jonas seems to no longer be working on these, I'm taking them over slowly. Here's my spec & SRPM that I propose to use to undeprecate rubygem-moneta: can you please review:
Again, I'm only planning to support EPEL6, not EPEL5, in addition to the Fedoras.
I will take this for a review.
1, Please move these files to -doc sub-package (they should not be part of the main package):
2, And exclude gem cache from the package using %exclude macro:
3, Tests should be part of this spec file alongside with the %check section, but I played with the upstream specs and they already differ too much to be tweaked for this version of the gem.
Rpmlint gives me no errors, package builds in mock and the package looks good otherwise.
Thanks Josef. I've updated the spec and SRPM for points 1 and 2.
Re point 3, I had the same problem with the spec tests. Looks like upstream did a lot more work on the specs after 0.6.0 was released but I couldn't get the ones tagged 0.6.0 to work.
Jonas, first of all, have you considered to replace moneta by juno  or something similar? I would say that this package is unmaintained by upstream and should not get into Fedora.
Otherwise, a few comments:
* Please drop the "Requires: ruby"
- Since we are going to share gems between JRuby and Ruby in F19, it would
pull in MRI even if not needed.
* Test suite
- I guess the test suite was developed for RSpec 1.x while you are trying to
run it with RSpec 2.x. The shared examples are typically troublesome.
- I am not going to dig more into it, but would you please mind to keep the
disabled %check section with appropriate comment in .spec file? It would
help during future updates (if there every will be some) to easily uncomment
and see what is the state of test suite.
Just a note regarding the test suite: It expects modules that have been added to the repository after the gem has been released (and the structure of the lib folder changed as well), so this is not a problem (or just a problem) with version of RSpec.
(In reply to comment #6)
Ups, sorry s/Jonas/Julian/
Actually, there is upstream ticket  to drop this dependency. Julian, could you please try to push Chef upstream a bit? Thank you.
(In reply to comment #9)
> Actually, there is upstream ticket  to drop this dependency. Julian,
> could you please try to push Chef upstream a bit? Thank you.
I will push them. It looks like there is an open ticket about this upstream, http://tickets.opscode.com/browse/CHEF-2984
Is it an absolute blocker to not have moneta in Fedora? I notice it used to be there and just got deprecated.
(In reply to comment #6)
> Jonas, first of all, have you considered to replace moneta by juno  or
> something similar? I would say that this package is unmaintained by upstream
> and should not get into Fedora.
> Otherwise, a few comments:
> * Please drop the "Requires: ruby"
> - Since we are going to share gems between JRuby and Ruby in F19, it would
> pull in MRI even if not needed.
> * Test suite
> - I guess the test suite was developed for RSpec 1.x while you are trying
> run it with RSpec 2.x. The shared examples are typically troublesome.
> - I am not going to dig more into it, but would you please mind to keep the
> disabled %check section with appropriate comment in .spec file? It would
> help during future updates (if there every will be some) to easily
> and see what is the state of test suite.
I have fixed these in the latest SPEC and SRPM on my fedorapeople page.
Everything is in the spec to run the tests if they ever get fixed, but the %check section is commented out with an explanation.
(In reply to comment #10)
> I will push them. It looks like there is an open ticket about this upstream,
Yes, that is the link I wanted to reference by my , but I missed it then ;)
> Is it an absolute blocker to not have moneta in Fedora? I notice it used to
> be there and just got deprecated.
I know it was in Fedora. At that time, it also could look that it is maintained etc. But it does not make sense to review some package which is already deprecated and there is a chance that it will be replaced by something else pretty soon.
So instead of doing two reviews, it may have be better to spend some time adapting Chef to used juno instead or drop the dependency entirely, as is referred in .
Also, I am afraid that there will be other blockers, such as rubygem-yajl-ruby, so there is no need to rush this review.
So no, it is not absolute blocker, but I think we should try to do it better.
I pulled a request to change Moneta dependency and use Juno instead .
(In reply to comment #13)
> I pulled a request to change Moneta dependency and use Juno instead .
>  https://github.com/opscode/chef/pull/552
Awesome, thanks Josef!
they released Juno under Moneta in the end , but Chef finally dropped the dependency of Moneta  so we don't need to pack it for Chef 11 (next release). Perhaps you can close this bug for now as deferred.
Josef, I agree with you -- I will close this as DEFERRED.