RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 823482 - qxl.inf in virtio-win-1.5 is not CRLF line terminator
Summary: qxl.inf in virtio-win-1.5 is not CRLF line terminator
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: virtio-win
Version: 6.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Jay Greguske
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-21 11:12 UTC by Xiaoqing Wei
Modified: 2012-06-20 11:58 UTC (History)
10 users (show)

Fixed In Version: virtio-win-1.5.2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-06-20 11:58:58 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2012:0751 0 normal SHIPPED_LIVE virtio-win bug fix and enhancement update 2012-06-19 19:31:22 UTC

Description Xiaoqing Wei 2012-05-21 11:12:30 UTC
Description of problem:

qxl.inf in virtio-win-1.5 is not CRLF line terminator
virtio-win is compose for Windows guests, so it's better to keep win style line terminator.

Version-Release number of selected component (if applicable):
virtio-win-1.5.1-1.el6.noarch

How reproducible:
100%

Steps to Reproduce:
1.# rpm -ivh virtio-win-1.5.1-1.el6.noarch
2.# find /usr/share/virtio-win/ -name \*.inf -exec file {} \;
3.
  
Actual results:
1) ALL except qxl.inf using UNIX style line terminators

Expected results:
ALL *.inf file should use Windows style line terminators(like 1.4.x)

Additional info:
1.4.x dont have such issue.

# mount -l | grep -i virtio-win
/home/kvm_autotest_root/iso/windows/virtio-win-1.4.0.vfd on /1.4 type vfat (ro,loop=/dev/loop0)
/home/kvm_autotest_root/iso/windows/virtio-win-1.5.1.vfd on /1.5 type vfat (ro,loop=/dev/loop1)

# find /1.4 /1.5 -name qxl.inf -exec file {} \;  
/1.4/i386/Win7/qxl.inf: ASCII English text, with CRLF line terminators
/1.4/i386/WinXP/qxl.inf: ASCII English text, with CRLF line terminators
/1.4/amd64/Win7/qxl.inf: ASCII English text, with CRLF line terminators
/1.5/i386/Win7/qxl.inf: ASCII English text
/1.5/i386/WinXP/qxl.inf: ASCII English text
/1.5/amd64/Win7/qxl.inf: ASCII English text

Comment 1 Xiaoqing Wei 2012-05-21 11:14:58 UTC
This doesn't impact driver installation manually, not high priority issue.

Setting M/M

Comment 4 Jay Greguske 2012-05-22 17:21:02 UTC
Adding Alon and Ronen. This was not intentional; can you guys confirm the QXL repo has CLRF terminators? They may have been lost when I did a git checkout to package them for virtio-win.

Since the installation is still successful, is this really a blocker?

Comment 5 Xiaoqing Wei 2012-05-23 01:49:29 UTC
(In reply to comment #4)

> Since the installation is still successful, is this really a blocker?

Oops, forgot to say that, if someone try to deal with these drivers by automated scripts, may failed due to the line terminator changed, 
such as autotest-kvm( though the autotest now updated and can deal with the non-CLRF line terminators).

Comment 6 Alon Levy 2012-05-23 08:14:01 UTC
(In reply to comment #4)
> Adding Alon and Ronen. This was not intentional; can you guys confirm the
> QXL repo has CLRF terminators? They may have been lost when I did a git
> checkout to package them for virtio-win.

$ file miniport/qxl.inf
miniport/qxl.inf: ASCII text, with CRLF, LF line terminators

yes.

The only real problem is to ensure that no file, including the ascii qxl.inf one, is changed after signature, or the verification will fail, and the driver won't install. We already had it once (qxl-win-<current-version - 1> was bad, qxl-win-<current version> fixed it). But no idea about autotest though, sounds like it should be minor as comment #5 said.

Comment 7 Xiaoqing Wei 2012-05-30 06:04:01 UTC
#mount -ro loop /usr/share/virtio-win/virtio-win-1.5.2.vfd /media/
# find /media/ -name *.inf -exec file {} \;
/media/i386/Win7/qxl.inf: ASCII English text, with CRLF line terminators
/media/i386/WinXP/qxl.inf: ASCII English text, with CRLF line terminators
/media/amd64/Win7/qxl.inf: ASCII English text, with CRLF line terminators

Checked virtio-win-1.5.2, qxl.inf is now CRLF too.

Comment 9 Mike Cao 2012-06-04 07:51:32 UTC
According to comment #7 ,this issue has been fixed ald 
Move status to verified.

Comment 10 errata-xmlrpc 2012-06-20 11:58:58 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0751.html


Note You need to log in before you can comment on or make changes to this bug.