Please modify this review request to follow this template ->   https://bugzilla.redhat.com/enter_bug.cgi?product=Fedora&format=fedora-review

Spec URL: http://git.chriscowley.me.uk/?p=rpms;a=blob_plain;f=SPECS/lessfs.spec;hb=8188095ebfe4f6cde9af34cb8ee2f26343ba8265
SRPM URL: http://yum.chriscowley.me.uk/fedora/rawhide/source/RPMS/lessfs-1.5.12-1.fc18.src.rpm
Description: A high performance inline data deduplicating filesystem for Linux.
Fedora Account System Username: chricowleyunix

The FAS name is actually chriscowleyunix. You don't seem to have a sponsor, therefore tagging the ticket.

The license seems to be GPLv3+, from what I see in lessfsck.c.

Please don't mix RPM_BUILD_ROOT and buildroot.

Do you plan to bring this package to EPEL 5? If not, several elements are not necessary (buildroot definition, clean section, rm in install section.)

Don't require gcc. It is available by default, see: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2

Don't require tokyocabinet explicitly. Rpm creates this dependency on its own.

Since this is a daemon, you'll need a system user to run the daemon as. In Fedora daemons need systemd unit files: http://fedoraproject.org/wiki/Packaging:Systemd

Also see http://fedoraproject.org/wiki/Packaging:ScriptletSnippets

Looking at lessfs.cfg, /var/lib/lessfs/mta is expected to exist. You must create and own this directory.

Please use the name macro in Source. ${version} should be %{version}.

I suppose you are aware of the process of becoming a packager? http://fedoraproject.org/wiki/Join_the_package_collection_maintainers

Mark the configuration file as such: http://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files

"/usr/bin/mklessfs" from the init script is certainly wrong, as you installed it to /usr/sbin.

What is that about? mkdir -p %{buildroot}/data

Thanks - I'm going to sit down and learn about Systemd now. I had kind of been avoiding it as all the systems at work are on Centos, and most them are version 5.

I had not really considered putting this into EPEL5, I will think about it.

I will also try and remember what that last mkdir line was for.

How's it going?

Chris, I will close this ticket as of http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews#Submitter_not_responding in a week.

Volker

I know this has stalled - I have just started a new job in a new country. As such FLOSS projects had to take a back seat over the last few months.

I will post an update asap.

How's it going?

I'll just close it for now. If you feel like working on it again, just re-open it.

*** Bug 530473 has been marked as a duplicate of this bug. ***

*** This bug has been marked as a duplicate of bug 1063171 ***