Bug 823666 - Explicit entry and exit points to profile mcollective calls in the log.
Summary: Explicit entry and exit points to profile mcollective calls in the log.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: OKD
Classification: Red Hat
Component: Pod
Version: 2.x
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: Rob Millner
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-21 20:05 UTC by Rob Millner
Modified: 2015-05-15 01:54 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2012-05-24 17:38:05 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Rob Millner 2012-05-21 20:05:14 UTC
Description of problem:
The profile merge script (rhc-profiler-merge-report) relies on inferring from the logs when a call begins and ends.  This is especially dicey for parallel calls which overlap.

Add specific log entries explicitly mark the start, end and duration of any call for profiling, parallel or not.

Version-Release number of selected component (if applicable):
rhc-node-0.93.2-1

How reproducible:
The ss_* mcollective calls cannot be profiled.  The parallel call data is inacurate.

Steps to Reproduce:
1. Do a benchmark run with profiling enabled
2. run rhc-profiler-merge-report on the resulting data

  
Actual results:
Missing or inaccurate call data.


Expected results:
Accurate call data.

Additional info:

Comment 1 Rob Millner 2012-05-23 21:12:27 UTC
I was able to work around this by having rhc-profiler-merge-report look for the log entry for YAML encoding the response if all else fails and add log entries to the mcollective log that it already knew to look for.

Passing to Q/A in case there's anything they'd like to verify; but this is basically just related to the benchmark Jenkins task.

Comment 2 Johnny Liu 2012-05-24 11:15:22 UTC
Hi Rob,

For QE, we never tested profiling stuff. I remembered the user story about profiling stuff is marked with "no need QE". If I am right, can you help verify this bug and verify it?


Thanks

Johnny

Comment 3 Rob Millner 2012-05-24 17:38:05 UTC
No need for Q/E.  Finishing the bug.


Note You need to log in before you can comment on or make changes to this bug.