As I am not sponsored, this isn't a formal review, but here are a couple of things:

-There's no source URL in the spec file, just "Source0: %{name}-%{version}.tar.gz". You should point this at the actual download from pypi.

-This is a Python package (it produces no compiled binaries), so it should be flagged as noarch using BuildArch: noarch. This will also get rid of the empty debuginfo package.

-Other than that, rpmlint identified a couple of other minor issues in both RPMs that should be easy to fix:

github-cli.src: W: summary-not-capitalized C command-line interface to the GitHub Issues API
github-cli.src: W: spelling-error %description -l en_US ghi -> ghee, hi, chi
github-cli.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 1)
github-cli.src: W: invalid-url Source0: github-cli-1.0.0.tar.gz

github-cli.x86_64: W: summary-not-capitalized C command-line interface to the GitHub Issues API
github-cli.x86_64: E: no-binary
github-cli.x86_64: W: no-documentation
github-cli.x86_64: W: no-manual-page-for-binary ghi
github-cli-debuginfo.x86_64: E: empty-debuginfo-package

(In reply to comment #1)
> As I am not sponsored, this isn't a formal review, but here are a couple of
> things:
> 
> -There's no source URL in the spec file, just "Source0:
> %{name}-%{version}.tar.gz". You should point this at the actual download
> from pypi.
> 
> -This is a Python package (it produces no compiled binaries), so it should
> be flagged as noarch using BuildArch: noarch. This will also get rid of the
> empty debuginfo package.
> 
> -Other than that, rpmlint identified a couple of other minor issues in both
> RPMs that should be easy to fix:
> 
> github-cli.src: W: summary-not-capitalized C command-line interface to the
> GitHub Issues API
> github-cli.src: W: spelling-error %description -l en_US ghi -> ghee, hi, chi
> github-cli.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line
> 1)
> github-cli.src: W: invalid-url Source0: github-cli-1.0.0.tar.gz
> 
> github-cli.x86_64: W: summary-not-capitalized C command-line interface to
> the GitHub Issues API
> github-cli.x86_64: E: no-binary
> github-cli.x86_64: W: no-documentation
> github-cli.x86_64: W: no-manual-page-for-binary ghi
> github-cli-debuginfo.x86_64: E: empty-debuginfo-package
I added all the fixes that u suggested:
Spec URL: http://alvesadrian.fedorapeople.org/github-cli.spec
SRPM URL: http://alvesadrian.fedorapeople.org/github-cli-1.0.0-2.fc16.src.rpm

I'm not completely sure about this- but wouldn't it be better to download a tarball of the source rather than using git and assuming the version number is 1.0.0? Especially when such a tarball is available from http://pypi.python.org/pypi/github-cli

If you use revision control, I think you need to make the version number a snapshot-style version number as described here: https://fedoraproject.org/wiki/Packaging:SourceURL and https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages

Is the line below supposed to make sure we have version 1.0.0? From the comment, I guess so, but catting this file doesn't actually do anything:

# cat src/github/version.py (Checkout the release version)

The only other thing is- this package currently has no documentation. Is there any available that could perhaps be included?

(In reply to comment #3)
> I'm not completely sure about this- but wouldn't it be better to download a
> tarball of the source rather than using git and assuming the version number
> is 1.0.0? Especially when such a tarball is available from
> http://pypi.python.org/pypi/github-cli
> 
> If you use revision control, I think you need to make the version number a
> snapshot-style version number as described here:
> https://fedoraproject.org/wiki/Packaging:SourceURL and
> https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages
> 
> Is the line below supposed to make sure we have version 1.0.0? From the
> comment, I guess so, but catting this file doesn't actually do anything:
> 
> # cat src/github/version.py (Checkout the release version)
> 
> The only other thing is- this package currently has no documentation. Is
> there any available that could perhaps be included?

I added all the fixes that u suggested:
Spec URL: http://alvesadrian.fedorapeople.org/github-cli.spec
SRPM URL: http://alvesadrian.fedorapeople.org/github-cli-1.0.0-3.fc16.src.rpm

Just two quick comments:

- -n %{name}-%{version} in %setup is not needed, this is the default.
- You have an unowned directory, https://fedoraproject.org/wiki/Packaging:UnownedDirectories

Any progress?

which way did u suggest?
%setup -qn %{name}-%{version}


which dir I unowned?


(In reply to comment #5)
> Just two quick comments:
> 
> - -n %{name}-%{version} in %setup is not needed, this is the default.
> - You have an unowned directory,
> https://fedoraproject.org/wiki/Packaging:UnownedDirectories

Scratch build for Rawhide fails:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4608626

From build.log:

+ /usr/bin/python setup.py build
Traceback (most recent call last):
  File "setup.py", line 3, in <module>
    from setuptools import setup, find_packages
ImportError: No module named setuptools

The package python-setuptools is missing from BuildRequires.

More issues:

%python_sitelib/github/*

First, please place curly brackets around macros to make them clearly distinguishable from other stuff. Moreover, the folder stays unowned this way. Either remove the asterisk to let it be owned or use the following construct:

%dir %{python_sitelib}/github
%{python_sitelib}/github/*

(In reply to comment #7)
> which way did u suggest?
> %setup -qn %{name}-%{version}

%setup -q

> which dir I unowned?

See comment from Mario

I added all the fixes that u suggested:
Spec URL: http://alvesadrian.fedorapeople.org/github-cli.spec
SRPM URL: http://alvesadrian.fedorapeople.org/github-cli-1.0.0-4.fc16.src.rpm

python-setuptools is still missing from BR. A Mock or Koji build will fail again.

Any news? Are you still interested in packaging it?

(In reply to comment #11)
> python-setuptools is still missing from BR. A Mock or Koji build will fail
> again.

working on that

(In reply to comment #12)
> Any news? Are you still interested in packaging it?

yes am working on a new release

(In reply to comment #14)
> (In reply to comment #12)
> > Any news? Are you still interested in packaging it?
> 
> yes am working on a new release

Please remove NotReady from the Whiteboard once you are done.

Hi,

I am interested in this package. I have fixed and updated the .spec file

Spec URL: https://bitbucket.org/dhiru/packages/raw/master/github-cli/github-cli.spec
SRPM URL: https://bitbucket.org/dhiru/packages/raw/master/github-cli/github-cli-1.0.0-5.fc19.src.rpm

http://koji.fedoraproject.org/koji/taskinfo?taskID=5908462

I think this package is useless, as GitHub has marked V2 API deprecated for a long time: https://github.com/blog/1160-github-api-v2-end-of-life

Currently github uses V3 API: http://developer.github.com/v3/

Anyone interested in V3 API binding in python? Or we write one? ;)

All people who are interested in integrating with github issues, please take a look at pygithub(in Fedora repo, but needs an update). I just tried with this from pypi, it works fine.

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days